Skip to content

Commit a1785ae

Browse files
committed
fixing agda#2280
1 parent dfd57bd commit a1785ae

File tree

4 files changed

+17
-23
lines changed

4 files changed

+17
-23
lines changed

src/Data/Integer/Divisibility.agda

+9-11
Original file line numberDiff line numberDiff line change
@@ -14,42 +14,40 @@ open import Function.Base using (_on_; _$_)
1414
open import Data.Integer.Base
1515
open import Data.Integer.Properties
1616
import Data.Nat.Base as ℕ
17-
import Data.Nat.Divisibility as ℕᵈ
17+
import Data.Nat.Divisibility as
1818
open import Level
1919
open import Relation.Binary.Core using (Rel; _Preserves_⟶_)
20-
open import Relation.Binary.PropositionalEquality
20+
2121

2222
------------------------------------------------------------------------
2323
-- Divisibility
2424

2525
infix 4 _∣_
2626

2727
_∣_ : Rel ℤ 0ℓ
28-
_∣_ = ℕᵈ._∣_ on ∣_∣
29-
30-
open ℕᵈ public using (divides)
28+
_∣_ = ℕ._∣_ on ∣_∣
3129

3230
------------------------------------------------------------------------
3331
-- Properties of divisibility
3432

3533
*-monoʳ-∣ : k (k *_) Preserves _∣_ ⟶ _∣_
3634
*-monoʳ-∣ k {i} {j} i∣j = begin
3735
∣ k * i ∣ ≡⟨ abs-* k i ⟩
38-
∣ k ∣ ℕ.* ∣ i ∣ ∣⟨ ℕᵈ.*-monoʳ-∣ ∣ k ∣ i∣j ⟩
39-
∣ k ∣ ℕ.* ∣ j ∣ ≡⟨ sym (abs-* k j) ⟩
36+
∣ k ∣ ℕ.* ∣ i ∣ ∣⟨ .*-monoʳ-∣ ∣ k ∣ i∣j ⟩
37+
∣ k ∣ ℕ.* ∣ j ∣ ≡⟨ abs-* k j
4038
∣ k * j ∣ ∎
41-
where open ℕᵈ.∣-Reasoning
39+
where open .∣-Reasoning
4240

4341
*-monoˡ-∣ : k (_* k) Preserves _∣_ ⟶ _∣_
4442
*-monoˡ-∣ k {i} {j} rewrite *-comm i k | *-comm j k = *-monoʳ-∣ k
4543

4644
*-cancelˡ-∣ : k {i j} .{{_ : NonZero k}} k * i ∣ k * j i ∣ j
47-
*-cancelˡ-∣ k {i} {j} k*i∣k*j = ℕᵈ.*-cancelˡ-∣ ∣ k ∣ $ begin
48-
∣ k ∣ ℕ.* ∣ i ∣ ≡⟨ sym (abs-* k i) ⟩
45+
*-cancelˡ-∣ k {i} {j} k*i∣k*j = .*-cancelˡ-∣ ∣ k ∣ $ begin
46+
∣ k ∣ ℕ.* ∣ i ∣ ≡⟨ abs-* k i
4947
∣ k * i ∣ ∣⟨ k*i∣k*j ⟩
5048
∣ k * j ∣ ≡⟨ abs-* k j ⟩
5149
∣ k ∣ ℕ.* ∣ j ∣ ∎
52-
where open ℕᵈ.∣-Reasoning
50+
where open .∣-Reasoning
5351

5452
*-cancelʳ-∣ : k {i j} .{{_ : NonZero k}} i * k ∣ j * k i ∣ j
5553
*-cancelʳ-∣ k {i} {j} rewrite *-comm i k | *-comm j k = *-cancelˡ-∣ k

src/Data/Integer/Divisibility/Signed.agda

+6-8
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,7 @@ module Data.Integer.Divisibility.Signed where
1111
open import Function.Base using (_⟨_⟩_; _$_; _$′_; _∘_; _∘′_)
1212
open import Data.Integer.Base
1313
open import Data.Integer.Properties
14-
open import Data.Integer.Divisibility as Unsigned
15-
using (divides)
16-
renaming (_∣_ to _∣ᵤ_)
14+
import Data.Integer.Divisibility as Unsigned
1715
import Data.Nat.Base as ℕ
1816
import Data.Nat.Divisibility as ℕ
1917
import Data.Nat.Coprimality as ℕ
@@ -45,9 +43,9 @@ open _∣_ using (quotient) public
4543
------------------------------------------------------------------------
4644
-- Conversion between signed and unsigned divisibility
4745

48-
∣ᵤ⇒∣ : {k i} k ∣ᵤ i k ∣ i
49-
∣ᵤ⇒∣ {k} {i} (divides 0 eq) = divides (+ 0) (∣i∣≡0⇒i≡0 eq)
50-
∣ᵤ⇒∣ {k} {i} (divides q@(ℕ.suc _) eq) with k ≟ +0
46+
∣ᵤ⇒∣ : {k i} k Unsigned.∣ i k ∣ i
47+
∣ᵤ⇒∣ {k} {i} (ℕ.divides 0 eq) = divides (+ 0) (∣i∣≡0⇒i≡0 eq)
48+
∣ᵤ⇒∣ {k} {i} (ℕ.divides q@(ℕ.suc _) eq) with k ≟ +0
5149
... | yes refl = divides +0 (∣i∣≡0⇒i≡0 (trans eq (ℕ.*-zeroʳ q)))
5250
... | no neq = divides (sign i Sign.* sign k ◃ q) (◃-cong sign-eq abs-eq)
5351
where
@@ -85,8 +83,8 @@ open _∣_ using (quotient) public
8583
∣ i ∣ ∎
8684
where open ≡-Reasoning
8785

88-
∣⇒∣ᵤ : {k i} k ∣ i k ∣ᵤ i
89-
∣⇒∣ᵤ {k} {i} (divides q eq) = divides ∣ q ∣ $′ begin
86+
∣⇒∣ᵤ : {k i} k ∣ i k Unsigned.∣ i
87+
∣⇒∣ᵤ {k} {i} (divides q eq) = ℕ.divides ∣ q ∣ $′ begin
9088
∣ i ∣ ≡⟨ cong ∣_∣ eq ⟩
9189
∣ q * k ∣ ≡⟨ abs-* q k ⟩
9290
∣ q ∣ ℕ.* ∣ k ∣ ∎

src/Data/Integer/GCD.agda

+1-2
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,9 @@ module Data.Integer.GCD where
1111
open import Data.Integer.Base
1212
open import Data.Integer.Divisibility
1313
open import Data.Integer.Properties
14-
open import Data.Nat.Base
1514
import Data.Nat.GCD as ℕ
1615
open import Data.Product.Base using (_,_)
17-
open import Relation.Binary.PropositionalEquality
16+
open import Relation.Binary.PropositionalEquality.Core using (_≡_; cong)
1817

1918
open import Algebra.Definitions {A = ℤ} _≡_ as Algebra
2019
using (Associative; Commutative; LeftIdentity; RightIdentity; LeftZero; RightZero; Zero)

src/Data/Integer/LCM.agda

+1-2
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,8 @@ module Data.Integer.LCM where
1111
open import Data.Integer.Base
1212
open import Data.Integer.Divisibility
1313
open import Data.Integer.GCD
14-
open import Data.Nat.Base using (ℕ)
1514
import Data.Nat.LCM as ℕ
16-
open import Relation.Binary.PropositionalEquality
15+
open import Relation.Binary.PropositionalEquality.Core using (_≡_; cong)
1716

1817
------------------------------------------------------------------------
1918
-- Definition

0 commit comments

Comments
 (0)