Skip to content

Commit d0f56e3

Browse files
committed
Update readme with Selenium compatibility and geckodriver instructions
1 parent 3916d20 commit d0f56e3

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

readme.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,9 @@ Before building or running for the first time:
1717
1. Install [Node.js](http://nodejs.org/download/)
1818
2. Install [Git](http://git-scm.com/downloads)
1919
3. Install [Firefox](http://getfirefox.com) (for smoke tests)
20-
3. Clone source repository: `git clone https://github.com/jamesshore/lets_code_javascript.git`
21-
4. All commands must run from root of repository: `cd lets_code_javascript`
20+
4. Install geckodriver into path (for smoke tests). On Mac, this is most easily done with [Homebrew](http://brew.sh/): `brew install geckodriver`. On Windows, [download geckodriver](https://github.com/mozilla/geckodriver/releases/) and manually add it to your path. On Linux, either download geckodriver manually or use your favorite package manager.
21+
5. Clone source repository: `git clone https://github.com/jamesshore/lets_code_javascript.git`
22+
6. All commands must run from root of repository: `cd lets_code_javascript`
2223

2324
*Note:* If you update the repository (with `git pull` or similar), be sure to erase generated files with `git clean -fdx` first. (Note that this will erase any files you've added, so be sure to check in what you want to keep first.)
2425

@@ -39,7 +40,7 @@ Compatibility notes:
3940

4041
* Episodes 1-9 don't work on case-sensitive file systems. To fix the problem, rename `jakefile.js` to `Jakefile.js` (with a capital 'J').
4142
* Episodes 37-39 don't work on Windows. A workaround is included in the episode 37 video.
42-
43+
* Episodes 269-441 and 469+ may fail when running smoke tests. They use Selenium for smoke testing and download the appropriate Firefox driver as needed. Those drivers may be missing or incompatible with your current version of Firefox. Starting with episode 469, Selenium uses geckodriver, which is installed separately from the rest of Selenium, which may make the smoke tests more reliable.
4344

4445
### To change Node versions and run the code:
4546

todo.txt

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@ Engineering Tasks:
4646
To Do on current task:
4747
* Confirm that the ghost pointer moved in the second browser
4848
- Consider using npm module 'geckodriver' rather than downloading geckodriver manually
49-
- Update readme: explain installing gecko-driver, mention `brew install geckodriver`
50-
- Update readme to reflect reproducibility issues with Selenium
51-
- BEFORE NEXT EPISODE
52-
- try it: Nice test of asynchronous code in http://www.letscodejavascript.com/v3/comments/live/465#comment-3015324687
49+
50+
- Viewer comments
51+
- Nice test of asynchronous code in http://www.letscodejavascript.com/v3/comments/live/465#comment-3015324687

0 commit comments

Comments
 (0)