Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global dark mode #279

Merged
merged 8 commits into from
Jan 30, 2025
Merged

Conversation

oliverfencott
Copy link
Contributor

This PR expands on the previous dark mode work and includes a fix provided by @elfenermarcell.

There are effectively 3 changes implemented:

  1. Fixes an erroneous CSS declaration for text-indent across all occurrences (with some minor whitespace formatting in applicable files).
  2. Collapses all dark mode rules into a single media query in each .css file.
  3. Appends the above CSS query to every .css file in static to enable dark mode across all versions of documentation.

Please note that 3. was done by a script that simply appends a string to all .css files that match (docpage.css, landing.css, main.css). I may have overlooked something obvious when doing this due to my lack of familiarity with the build tools and project structure.

@sogaiu
Copy link
Collaborator

sogaiu commented Jan 29, 2025

I clicked through to see the results for the "Data Structures" page [1] and the "Parsing Expression Grammars" page [2] for all of the versions linked at the top of the pages (the links that come after "Other Versions").

It looks pretty good!

@elfenermarcell How does it look to you? May be this PR sufficiently addresses things that #278 was meant to attend to?


If anyone else is interested in seeing the changes, the "Data Structures" page is easier to see effects of the changes for the tables as scrolling may not be required (^^;


[1] http://localhost:8000/docs/data_structures/index.html

[2] http://localhost:8000/docs/peg.html

@elfenermarcell
Copy link
Contributor

Looks correct. The tables look right in dark mode, and dark mode works in every version. I'll close my PR #278.

@bakpakin bakpakin merged commit dd5788b into janet-lang:master Jan 30, 2025
1 check passed
@oliverfencott oliverfencott deleted the global-dark-mode branch January 30, 2025 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants