Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logistic / Multinomial regression #369

Merged
merged 30 commits into from
Sep 13, 2024
Merged

Conversation

koenderks
Copy link
Collaborator

@koenderks koenderks commented Sep 9, 2024

Implements a combination of logistic regression (when the target variable has 2 levels) and multinomial regression (when the target variable has >2 levels). I believe this was (about to be) requested as a feature.

@koenderks koenderks marked this pull request as ready for review September 10, 2024 22:26
@koenderks koenderks requested a review from vandenman September 10, 2024 22:26
Copy link
Contributor

@vandenman vandenman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, still have to try this out in jasp though.

@koenderks koenderks requested a review from vandenman September 11, 2024 09:01
@koenderks koenderks requested a review from vandenman September 11, 2024 11:03
@koenderks
Copy link
Collaborator Author

I fixed some minor bugs but am quite finished with this analysis. Let's try to get it in the next release but take your time with reviewing and/or testing this. I don't think a new release is coming very soon. I'm also fine with merging it and then testing more throughly in the testing cycle.

Copy link
Contributor

@vandenman vandenman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, nice work!

@vandenman vandenman merged commit fb42caf into jasp-stats:master Sep 13, 2024
5 checks passed
@koenderks koenderks deleted the logitreg branch September 13, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants