Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make explain predictions work for new data again #393

Merged
merged 5 commits into from
Nov 25, 2024

Conversation

koenderks
Copy link
Collaborator

@koenderks koenderks commented Nov 22, 2024

Started out as a bugfix for the Explain predictions table in mlPrediction, but turned into an optimisation where I removed the need to encode jaspML objects entirely! I verified that the predictions work with all models.

If you want to test yourself:

  • Training dataset (Iris from Data Library): iris.csv
  • All models trained on Iris dataset (classification predicts Species, regression predicts Sepal.Length): models.zip
  • Prediction dataset with column names in different order than in training data: predictionData.csv

@koenderks koenderks requested a review from vandenman November 22, 2024 10:48
Copy link
Contributor

@vandenman vandenman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, one minor remark

@koenderks koenderks requested a review from vandenman November 25, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants