Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release fixes #193

Merged
merged 4 commits into from
Dec 6, 2024
Merged

Release fixes #193

merged 4 commits into from
Dec 6, 2024

Conversation

@FBartos FBartos requested a review from boutinb November 26, 2024 16:45
@boutinb
Copy link
Contributor

boutinb commented Dec 2, 2024

@FBartos
Copy link
Collaborator Author

FBartos commented Dec 3, 2024

The jasp-stats/jasp-test-release#2807 still fails

well, you cannot untick the intercept, so you cannot reproduce the error in other way than loading the data set :)

@FBartos FBartos requested review from RensDofferhoff and removed request for boutinb December 4, 2024 10:49
@RensDofferhoff
Copy link
Contributor

@boutinb @FBartos should I just alter the datalib files by checking intercept?

@FBartos
Copy link
Collaborator Author

FBartos commented Dec 5, 2024

I think the data lib files do have checked intercept -- this error occurred once the intercept was unchecked

@boutinb
Copy link
Contributor

boutinb commented Dec 5, 2024

think the data lib files do have checked intercept -- this error occurred once the intercept was unchecked

I'm not sure to understand: if I load a csv file, I add the Bayesian Linear Mixed Model, I set a dependent variable, a fixed effects and a Random effect, and then unset the 'Include intercept': i get this error.
If I do that with the Classical Linear Mixed Model, I don't get any error.
In 0.19.1, we have the same problem.
If in the Bayesian version, the Intercept must be always set, then let's disable it.

@FBartos
Copy link
Collaborator Author

FBartos commented Dec 6, 2024

I'm not sure to understand: if I load a csv file, I add the Bayesian Linear Mixed Model, I set a dependent variable, a fixed effects and a Random effect, and then unset the 'Include intercept': i get this error.
If I do that with the Classical Linear Mixed Model, I don't get any error.
In 0.19.1, we have the same problem.
If in the Bayesian version, the Intercept must be always set, then let's disable it.

Yes, indeed, that's what this PR does
https://github.com/jasp-stats/jaspMixedModels/pull/193/files#diff-8d00a9863284d8353ec247264278f6a683e47ede754168d1eeec45cab4150ea9R66-R69
and
https://github.com/jasp-stats/jaspMixedModels/pull/193/files#diff-b24bbd7477efa6362f979b53402ed5a9a0a9939bd5f3271f0e0f03f5731a5b8aR51-R54

@boutinb
Copy link
Contributor

boutinb commented Dec 6, 2024

Ok, then we can merge this, @RensDofferhoff ?

Copy link
Contributor

@RensDofferhoff RensDofferhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

@FBartos FBartos merged commit 9128378 into jasp-stats:master Dec 6, 2024
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants