fix ArchConfigurationRule default

By default `ArchConfigurationRule` should use the configured `resolveAdditionalDependenciesFromClassPath` instead of the `boolean` default `false`. Unfortunately this masked that `@Before void setUp() { configuration.... }` does actually not do anything, since `@Before` runs after the rule `before` and the rule `before` sets the configuration.

Signed-off-by: Peter Gafert <[email protected]>

Author: codecholeric

archunit/src/test/java/com/tngtech/archunit/core/domain/SourceCodeLocationTest.java

@@ -1,52 +1,46 @@
-package com.tngtech.archunit.core.domain;
-
-import java.util.ArrayList;
-
-import com.tngtech.archunit.testutil.ArchConfigurationRule;
-import org.assertj.core.api.Assertions;
-import org.junit.Before;
-import org.junit.Rule;
-import org.junit.Test;
-
-import static com.tngtech.archunit.core.domain.TestUtils.importClassWithContext;
-import static com.tngtech.archunit.testutil.Assertions.assertThat;
-
-public class SourceCodeLocationTest {
-
-    @Rule
-    public final ArchConfigurationRule configuration = new ArchConfigurationRule();
-
-    @Before
-    public void setUp() {
-        // We need this to create a JavaClass without source, i.e. a stub because the class is missing and cannot be resolved
-        configuration.resolveAdditionalDependenciesFromClassPath(false);
-    }
-
-    @Test
-    public void format_location() {
-        JavaClass classWithSource = importClassWithContext(Object.class);
-
-        assertThat(classWithSource.getSource()).as("source").isPresent();
-        Assertions.assertThat(SourceCodeLocation.of(classWithSource, 7).toString()).isEqualTo("(Object.java:7)");
-
-        JavaClass classWithoutSource = getClassWithoutSource();
-
-        assertThat(classWithoutSource.getSource()).as("source").isAbsent();
-        Assertions.assertThat(SourceCodeLocation.of(classWithoutSource, 7).toString()).isEqualTo(String.format("(%s.java:7)", classWithoutSource.getSimpleName()));
-    }
-
-    private JavaClass getClassWithoutSource() {
-        for (JavaAccess<?> javaAccess : importClassWithContext(SomeClass.class).getAccessesFromSelf()) {
-            if (javaAccess.getTargetOwner().isEquivalentTo(ArrayList.class)) {
-                return javaAccess.getTargetOwner();
-            }
-        }
-        throw new RuntimeException("Could not create any java class without source");
-    }
-
-    private static class SomeClass {
-        public SomeClass() {
-            new ArrayList<>();
-        }
-    }
-}
+package com.tngtech.archunit.core.domain;
+
+import java.util.ArrayList;
+
+import com.tngtech.archunit.testutil.ArchConfigurationRule;
+import org.assertj.core.api.Assertions;
+import org.junit.Rule;
+import org.junit.Test;
+
+import static com.tngtech.archunit.core.domain.TestUtils.importClassWithContext;
+import static com.tngtech.archunit.testutil.Assertions.assertThat;
+
+public class SourceCodeLocationTest {
+
+    // We need this to create a JavaClass without source, i.e. a stub because the class is missing and cannot be resolved
+    @Rule
+    public final ArchConfigurationRule configuration = new ArchConfigurationRule().resolveAdditionalDependenciesFromClassPath(false);
+
+    @Test
+    public void format_location() {
+        JavaClass classWithSource = importClassWithContext(Object.class);
+
+        assertThat(classWithSource.getSource()).as("source").isPresent();
+        Assertions.assertThat(SourceCodeLocation.of(classWithSource, 7).toString()).isEqualTo("(Object.java:7)");
+
+        JavaClass classWithoutSource = getClassWithoutSource();
+
+        assertThat(classWithoutSource.getSource()).as("source").isAbsent();
+        Assertions.assertThat(SourceCodeLocation.of(classWithoutSource, 7).toString()).isEqualTo(String.format("(%s.java:7)", classWithoutSource.getSimpleName()));
+    }
+
+    private JavaClass getClassWithoutSource() {
+        for (JavaAccess<?> javaAccess : importClassWithContext(SomeClass.class).getAccessesFromSelf()) {
+            if (javaAccess.getTargetOwner().isEquivalentTo(ArrayList.class)) {
+                return javaAccess.getTargetOwner();
+            }
+        }
+        throw new RuntimeException("Could not create any java class without source");
+    }
+
+    private static class SomeClass {
+        public SomeClass() {
+            new ArrayList<>();
+        }
+    }
+}

archunit/src/test/java/com/tngtech/archunit/testutil/ArchConfigurationRule.java

@@ -4,7 +4,7 @@
 import org.junit.rules.ExternalResource;
 
 public class ArchConfigurationRule extends ExternalResource {
-    private boolean resolveMissingDependenciesFromClassPath;
+    private boolean resolveMissingDependenciesFromClassPath = ArchConfiguration.get().resolveMissingDependenciesFromClassPath();
 
     public ArchConfigurationRule resolveAdditionalDependenciesFromClassPath(boolean enabled) {
         resolveMissingDependenciesFromClassPath = enabled;