Applied code style (zalando#1026)

Author: whiskeysierra

logbook-core/src/main/java/org/zalando/logbook/Conditions.java

@@ -78,8 +78,8 @@ public static <T extends HttpMessage> Predicate<T> header(final BiPredicate<Stri
                                 e.getValue().stream().anyMatch(v -> predicate.test(e.getKey(), v)));
     }
 
-    public static <T extends HttpMessage> Predicate<T> withoutHeader(String headerName) {
-        return message -> !message.getHeaders().containsKey(headerName);
+    public static <T extends HttpMessage> Predicate<T> withoutHeader(final String key) {
+        return message -> !message.getHeaders().containsKey(key);
     }
 
 }

logbook-core/src/test/java/org/zalando/logbook/ConditionsTest.java

@@ -158,20 +158,30 @@ void headerShouldNotMatchPredicateWhenHeaderIsAbsent() {
     }
 
     @Test
-    void withoutHeader() {
-        final Predicate<HttpMessage> unit = Conditions.withoutHeader("Authorization");
+    void matchesWithoutHeader() {
+        final Predicate<HttpMessage> unit = withoutHeader("Authorization");
 
         assertThat(unit.test(request)).isTrue();
     }
 
     @Test
-    void withEmptyHeader() {
-        final MockHttpRequest requestWithEmptyAuthorizationHeader = MockHttpRequest.create()
-                                                                                   .withHeaders(HttpHeaders.of("Authorization", ""))
-                                                                                   .withContentType("application/json");
+    void doesNotMatchWithHeader() {
+        final MockHttpRequest request = this.request
+                .withHeaders(HttpHeaders.of("Authorization", "Bearer Unw62Gp9okJFN1AAHm8xtR"));
 
-        final Predicate<HttpMessage> unit = Conditions.withoutHeader("Authorization");
+        final Predicate<HttpMessage> unit = withoutHeader("Authorization");
 
-        assertThat(unit.test(requestWithEmptyAuthorizationHeader)).isFalse();
+        assertThat(unit.test(request)).isFalse();
+    }
+
+    @Test
+    void doesNotMatchWithEmptyHeaderValue() {
+        final MockHttpRequest request = this.request
+                .withHeaders(HttpHeaders.of("Authorization", ""));
+
+        final Predicate<HttpMessage> unit = withoutHeader("Authorization");
+
+        assertThat(unit.test(request)).isFalse();
     }
+
 }