Skip to content

Commit 9831b86

Browse files
committed
fixes #1599
1 parent 09da2a9 commit 9831b86

File tree

5 files changed

+14
-14
lines changed

5 files changed

+14
-14
lines changed

Diff for: 2-ui/1-document/11-coordinates/3-position-at-absolute/solution.view/index.html

+2-2
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,8 @@
2828
let box = elem.getBoundingClientRect();
2929

3030
return {
31-
top: box.top + pageYOffset,
32-
left: box.left + pageXOffset
31+
top: box.top + window.pageYOffset,
32+
left: box.left + window.pageXOffset
3333
};
3434
}
3535

Diff for: 2-ui/1-document/11-coordinates/4-position-inside-absolute/solution.view/index.html

+2-2
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,8 @@
2626
let box = elem.getBoundingClientRect();
2727

2828
return {
29-
top: box.top + pageYOffset,
30-
left: box.left + pageXOffset
29+
top: box.top + window.pageYOffset,
30+
left: box.left + window.pageXOffset
3131
};
3232
}
3333

Diff for: 2-ui/1-document/11-coordinates/article.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -215,8 +215,8 @@ function getCoords(elem) {
215215
let box = elem.getBoundingClientRect();
216216
217217
return {
218-
top: box.top + pageYOffset,
219-
left: box.left + pageXOffset
218+
top: box.top + window.pageYOffset,
219+
left: box.left + window.pageXOffset
220220
};
221221
}
222222
```

Diff for: 2-ui/3-event-details/4-mouse-drag-and-drop/2-drag-heroes/solution.view/soccer.js

+7-7
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ document.addEventListener('mousedown', function(event) {
77
if (!dragElement) return;
88

99
event.preventDefault();
10-
10+
1111
dragElement.ondragstart = function() {
1212
return false;
1313
};
@@ -19,7 +19,7 @@ document.addEventListener('mousedown', function(event) {
1919
function onMouseUp(event) {
2020
finishDrag();
2121
};
22-
22+
2323
function onMouseMove(event) {
2424
moveAt(event.clientX, event.clientY);
2525
}
@@ -31,9 +31,9 @@ document.addEventListener('mousedown', function(event) {
3131
if(isDragging) {
3232
return;
3333
}
34-
34+
3535
isDragging = true;
36-
36+
3737
document.addEventListener('mousemove', onMouseMove);
3838
element.addEventListener('mouseup', onMouseUp);
3939

@@ -50,10 +50,10 @@ document.addEventListener('mousedown', function(event) {
5050
if(!isDragging) {
5151
return;
5252
}
53-
53+
5454
isDragging = false;
5555

56-
dragElement.style.top = parseInt(dragElement.style.top) + pageYOffset + 'px';
56+
dragElement.style.top = parseInt(dragElement.style.top) + window.pageYOffset + 'px';
5757
dragElement.style.position = 'absolute';
5858

5959
document.removeEventListener('mousemove', onMouseMove);
@@ -113,4 +113,4 @@ document.addEventListener('mousedown', function(event) {
113113
dragElement.style.top = newY + 'px';
114114
}
115115

116-
});
116+
});

Diff for: 2-ui/3-event-details/8-onscroll/article.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ Here's a small function to show the current scroll:
1010

1111
```js autorun
1212
window.addEventListener('scroll', function() {
13-
document.getElementById('showScroll').innerHTML = pageYOffset + 'px';
13+
document.getElementById('showScroll').innerHTML = window.pageYOffset + 'px';
1414
});
1515
```
1616

0 commit comments

Comments
 (0)