Merge pull request #29 from jay7x/start_jobs

Make start VM jobs configurable

Author: jay7x

plans/cluster/start.pp

@@ -1,12 +1,15 @@
 # @summary Start the cluster of Lima VMs
 # @param name
 #   Cluster name
+# @param jobs
+#   How much VMs to start in parallel
 # @param clusters
 #   Hash of all defined clusters. Populated from Hiera usually.
 # @param target
 #   The host to run the limactl on
 plan lima::cluster::start (
   String[1] $name,
+  Integer[0] $jobs = 0,
   Optional[Hash] $clusters = undef,
   TargetSpec $target = 'localhost',
 ) {
@@ -36,22 +39,24 @@
     fail_plan("Some nodes are missing: ${missing_nodes}", 'lima/missing-nodes', missing_nodes => $missing_nodes)
   }
 
-  # Collect and set the target's facts
-  if empty(facts($tgt)) {
-    without_default_logging() || {
-      run_plan('facts', $tgt, _catch_errors => true)
+  $start_jobs = if $jobs > 0 {
+    $jobs
+  } else {
+    if $tgt.facts.length < 1 {
+      without_default_logging() || {
+        run_plan('facts', $tgt, _catch_errors => true)
+      }
     }
+    $cpus = $tgt.facts.get('processors.count', 1)
+    if $cpus < 4 { 1 } else { $cpus / 2 } # Assume every VM can consume up to 200% of a CPU core on start
   }
-  $cpus = facts($tgt).get('processors.count', 1)
-  # FIXME: make start_threads configurable
-  $start_threads = if $cpus < 4 { 1 } else { $cpus / 2 } # Assume every VM can consume up to 200% of a CPU core on start
 
   # Start stopped nodes
   $stopped_nodes = $lima_list.filter |$x| { $x['status'] == 'Stopped' }.map |$x| { $x['name'] }
-  out::verbose("Nodes to start (${start_threads} nodes per batch): ${stopped_nodes}")
+  out::verbose("Nodes to start (${start_jobs} nodes per batch): ${stopped_nodes}")
 
-  # Run in batches of $start_threads VMs in parallel
-  $start_res = $stopped_nodes.slice($start_threads).map |$batch| {
+  # Run in batches of $start_jobs VMs in parallel
+  $start_res = $stopped_nodes.slice($start_jobs).map |$batch| {
     $batch.parallelize |$node| {
       run_task('lima::start', $tgt, name => $node)
     }

spec/plans/cluster/start_spec.rb

@@ -43,7 +43,8 @@
     }
   end
   let(:nodes_to_start) { [nodes[0], nodes[1], nodes[3], nodes[4]] }
-  let(:plan_params) { { 'name' => cluster_name, 'clusters' => clusters } }
+  let(:jobs) { nil }
+  let(:plan_params) { { 'name' => cluster_name, 'clusters' => clusters, 'jobs' => jobs } }
   let(:facts) { { 'processors': { 'count': 1 } } }
 
   context 'with non-existent cluster' do
@@ -81,14 +82,32 @@
         expect_task('lima::start').be_called_times(1).with_params('name' => node).always_return(start: true)
       end
       expect_out_verbose.with_params("Defined nodes: [#{nodes.join(', ')}]")
-      expect_out_verbose.with_params("Nodes to start (1 nodes per batch): [#{nodes_to_start.join(', ')}]")
     end
 
-    it 'starts all stopped nodes in the cluster' do
-      result = run_plan(plan, plan_params)
+    context 'with no jobs specified' do
+      it 'starts all stopped nodes in the cluster' do
+        expect_task('facts').be_called_times(1)
+        expect_out_verbose.with_params("Nodes to start (1 nodes per batch): [#{nodes_to_start.join(', ')}]")
+
+        result = run_plan(plan, plan_params)
+
+        expect(result.ok?).to be(true)
+        expect(result.value.count).to eq(nodes_to_start.length)
+      end
+    end
 
-      expect(result.ok?).to be(true)
-      expect(result.value.count).to eq(nodes_to_start.length)
+    context 'with jobs=>2' do
+      let(:jobs) { 2 }
+
+      it 'starts all stopped nodes in the cluster' do
+        expect_task('facts').be_called_times(0)
+        expect_out_verbose.with_params("Nodes to start (#{jobs} nodes per batch): [#{nodes_to_start.join(', ')}]")
+
+        result = run_plan(plan, plan_params)
+
+        expect(result.ok?).to be(true)
+        expect(result.value.count).to eq(nodes_to_start.length / jobs)
+      end
     end
   end
 end