Merge "Revert "Stop writing coverage data in coverage-flush signal handler""

Author: pirama-arumuga-nainar

toolchain-extras/Android.bp

@@ -46,6 +46,7 @@ cc_library_static {
 cc_defaults {
     name: "libprofile-clang-defaults",
     srcs: [
+        "profile-clang-extras.cpp",
         "profile-clang-openat.cpp",
     ],
     native_coverage: false,

toolchain-extras/profile-clang-extras-test.cpp

@@ -20,6 +20,24 @@
 
 #include "profile-extras.h"
 
+static int flush_count = 0;
+
+extern "C" {
+int __llvm_profile_write_file() {
+  flush_count++;
+  return 0;
+}
+}
+
+TEST(profile_extras, smoke) {
+  flush_count = 0;
+
+  ASSERT_EQ(0, flush_count);
+  kill(getpid(), COVERAGE_FLUSH_SIGNAL);
+  sleep(2);
+  ASSERT_EQ(1, flush_count);
+}
+
 static const char* OPEN_AT_TEST_FNAME = "/data/misc/trace/test.profraw";
 TEST(profile_extras, openat) {
   mode_t old_umask = umask(0077);

toolchain-extras/profile-clang-extras.cpp

@@ -0,0 +1,58 @@
+/*
+ * Copyright (C) 2020 The Android Open Source Project
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#include <errno.h>
+#include <signal.h>
+#include <stdlib.h>
+
+#include "profile-extras.h"
+
+extern "C" {
+
+static sighandler_t chained_signal_handler = SIG_ERR;
+
+int __llvm_profile_write_file(void);
+
+static void llvm_signal_handler(__unused int signum) {
+  __llvm_profile_write_file();
+
+  if (chained_signal_handler != SIG_ERR && chained_signal_handler != SIG_IGN &&
+      chained_signal_handler != SIG_DFL) {
+    (chained_signal_handler)(signum);
+  }
+}
+
+// Initialize libprofile-extras:
+//
+// - Install a signal handler that triggers __llvm_profile_write_file on
+// <COVERAGE_FLUSH_SIGNAL>.
+//
+// We want this initializer to run during load time.  In addition to marking
+// this function as a constructor, we link this library with `--whole-archive`
+// to force this function to be included in the output.
+static __attribute__((constructor)) int init_profile_extras(void) {
+  if (chained_signal_handler != SIG_ERR) {
+    return -1;
+  }
+  sighandler_t ret1 = signal(COVERAGE_FLUSH_SIGNAL, llvm_signal_handler);
+  if (ret1 == SIG_ERR) {
+    return -1;
+  }
+  chained_signal_handler = ret1;
+
+  return 0;
+}
+}