Skip to content

Commit 7c1ac35

Browse files
cferris1000Gerrit Code Review
authored and
Gerrit Code Review
committed
Merge "Update for MapInfo objects in frame data."
2 parents 6934c6e + accebda commit 7c1ac35

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

simpleperf/OfflineUnwinder.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -274,17 +274,17 @@ bool OfflineUnwinderImpl::UnwindCallChain(const ThreadEntry& thread, const RegSe
274274
for (auto& frame : unwinder.frames()) {
275275
// Unwinding in arm architecture can return 0 pc address.
276276

277-
// If frame.map.start == 0, this frame doesn't hit any map, it could be:
277+
// If frame.map_info == nullptr, this frame doesn't hit any map, it could be:
278278
// 1. In an executable map not backed by a file. Note that RecordCommand::ShouldOmitRecord()
279279
// may omit maps only exist memory.
280-
// 2. An incorrectly unwound frame. Like caused by invalid stack data, as in
280+
// 2. An incorrectly unwound frame. Likely caused by invalid stack data, as in
281281
// SampleRecord::GetValidStackSize(). Or caused by incomplete JIT debug info.
282282
// We want to remove this frame and callchains following it in either case.
283-
if (frame.pc == 0 || frame.map_start == 0) {
283+
if (frame.map_info == nullptr) {
284284
is_callchain_broken_for_incomplete_jit_debug_info_ = true;
285285
break;
286286
}
287-
if (frame.map_flags & unwindstack::MAPS_FLAGS_JIT_SYMFILE_MAP) {
287+
if (frame.map_info->flags() & unwindstack::MAPS_FLAGS_JIT_SYMFILE_MAP) {
288288
last_jit_method_frame = ips->size();
289289
}
290290
ips->push_back(frame.pc);

0 commit comments

Comments
 (0)