From 3fd114105d7bc3ce471a8f69ea2ee55faeb07522 Mon Sep 17 00:00:00 2001 From: Julian Bilcke Date: Sat, 24 Aug 2024 17:22:09 +0200 Subject: [PATCH] update readme and fix cyclic dependency --- README.md | 14 ++++++++------ packages/app/src/services/debug.ts | 2 +- packages/broadway/src/factories/generateClap.ts | 3 --- packages/timeline/src/hooks/useTimeline.ts | 2 -- 4 files changed, 9 insertions(+), 12 deletions(-) diff --git a/README.md b/README.md index e0c30806..80c7ada4 100644 --- a/README.md +++ b/README.md @@ -30,6 +30,14 @@ To this end I am also working on a Director's Mode, where you can just put the v A public instance of Clapper is currently hosted on [Hugging Face](https://huggingface.co/spaces/jbilcke-hf/clapper/tree/main), you can try it at [Clapper.app](https://clapper.app/) +# Open-source philosophy + +The whole the project is open-source. + +To participate, please join us on [Discord](https://discord.com/invite/AEruz9B92B). + +The roadmap is public, too: [https://github.com/users/jbilcke-hf/projects/6/views/1](Clapper roadmap). + # Badges - Build and tests status: [![E2E & Unit Tests](https://github.com/jbilcke-hf/clapper/actions/workflows/tests.yml/badge.svg)](https://github.com/jbilcke-hf/clapper/actions/workflows/tests.yml) @@ -50,12 +58,6 @@ Those generous sponsors are paying for code bounties: !! ATTENTION: there is currently an issue with the platform we initially used for bounties. We are looking for an alternative solution. !! -If you wish to sponsor the project, help attract new developers, or promote a specific feature faster, you can open a bounty for a specific ticket (eg `"fix music segment duration"`, `"add support for Adobe Premiere Pro export"`, `"finish .fbx integration"`) and open-source community members will be able to submit pull requests to solve them. - -If you submit (to pay) or take on (to earn) a bounty, please post a message in the GitHub thread and/or on [Discord](https://discord.com/invite/AEruz9B92B) to help everyone coordinate around it. - -I am currently working to add documentation to help onboard new developers, this should help new people taking on bounties. - ## For developers ### Licence diff --git a/packages/app/src/services/debug.ts b/packages/app/src/services/debug.ts index 5c76e6a2..c24b99a5 100644 --- a/packages/app/src/services/debug.ts +++ b/packages/app/src/services/debug.ts @@ -39,6 +39,7 @@ if (typeof window !== 'undefined') { // w.useEditors = useEditors // w.useWorkflowEditor = useWorkflowEditor // w.useIO = useIO + // w.useSettings = useSettings w.useEntityEditor = useEntityEditor w.useFilterEditor = useFilterEditor @@ -49,7 +50,6 @@ if (typeof window !== 'undefined') { w.useMonitor = useMonitor w.useRenderer = useRenderer w.useResolver = useResolver - w.useSettings = useSettings w.useSimulator = useSimulator w.useUI = useUI w.useWindows = useWindows diff --git a/packages/broadway/src/factories/generateClap.ts b/packages/broadway/src/factories/generateClap.ts index bdd9a14a..9a4e7b40 100644 --- a/packages/broadway/src/factories/generateClap.ts +++ b/packages/broadway/src/factories/generateClap.ts @@ -43,9 +43,6 @@ export async function generateClap({ const useCompactMode = !embedded - // const win = (window as any) - // win.debugJulian = segments - let highestEndTimeInMs = 0 const clapSegments: ClapSegment[] = segments.map(maybeSegment => { diff --git a/packages/timeline/src/hooks/useTimeline.ts b/packages/timeline/src/hooks/useTimeline.ts index fe3f1900..a4169557 100644 --- a/packages/timeline/src/hooks/useTimeline.ts +++ b/packages/timeline/src/hooks/useTimeline.ts @@ -36,8 +36,6 @@ export const useTimeline = create((set, get) => ({ return } - (window as any).useTimeline = useTimeline - set({ isLoading: true }) // actually you know what.. let's drop the concept of final video for the moment