Skip to content

Commit 47c2b81

Browse files
authored
fix: removeFilteredNamedGroupingPolicy "" filtered (#62)
* fix: removeFilteredNamedGroupingPolicy "" filtered * refactor: removeFilteredPolicy * refactor: removeFilteredPolicy again * fix: update node-version * refactor: removeFilteredPolicy 2
1 parent c0435fe commit 47c2b81

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

.github/workflows/maven-ci.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ jobs:
7171
- name: Set up Node.js
7272
uses: actions/setup-node@v2
7373
with:
74-
node-version: 16
74+
node-version: 18
7575

7676
- name: Sematic Release
7777
run: |

src/main/java/org/casbin/adapter/JDBCBaseAdapter.java

+6-4
Original file line numberDiff line numberDiff line change
@@ -473,14 +473,16 @@ public void removeFilteredPolicy(String sec, String ptype, int fieldIndex, Strin
473473
}
474474
String sql = renderActualSql("DELETE FROM casbin_rule WHERE ptype = ?");
475475
int columnIndex = fieldIndex;
476-
for (int i = 0; i < values.size(); i++) {
476+
for (int i = 0; i < values.size(); i++, columnIndex++) {
477+
if (Objects.equals(values.get(i), "")) continue;
477478
sql = String.format("%s%s%s%s", sql, " AND v", columnIndex, " = ?");
478-
columnIndex++;
479479
}
480480
try (PreparedStatement ps = conn.prepareStatement(sql)) {
481481
ps.setString(1, ptype);
482-
for (int j = 0; j < values.size(); j++) {
483-
ps.setString(j + 2, values.get(j));
482+
int index = 2;
483+
for (String value : values) {
484+
if (Objects.equals(value, "")) continue;
485+
ps.setString(index++, value);
484486
}
485487
int rows = ps.executeUpdate();
486488
if (rows < 1 && removePolicyFailed) {

0 commit comments

Comments
 (0)