Fix 'historical_order_data'

Author: jogobeny

trading212/models.py

@@ -185,32 +185,32 @@ class Tax(BaseModel):
 
 class HistoryItem(BaseModel):
     dateCreated: datetime
-    dateExecuted: datetime
+    dateExecuted: datetime | None
     dateModified: datetime
     executor: str
-    fillCost: float
-    fillId: int
-    fillPrice: float
-    fillResult: float
-    fillType: str
-    filledQuantity: float
-    filledValue: float
+    fillCost: float | None
+    fillId: int | None
+    fillPrice: float | None
+    fillResult: float | None
+    fillType: str | None
+    filledQuantity: float | None
+    filledValue: float | None
     id: int
-    limitPrice: float
-    orderedQuantity: float
-    orderedValue: float
+    limitPrice: float | None
+    orderedQuantity: float | None
+    orderedValue: float | None
     parentOrder: int
     status: str
-    stopPrice: float
+    stopPrice: float | None
     taxes: List[Tax]
     ticker: str
-    timeValidity: str
+    timeValidity: str | None
     type: str
 
 
 class HistoricalOrderData(BaseModel):
     items: List[HistoryItem]
-    nextPagePath: str
+    nextPagePath: str | None
 
 
 class LimitOrder(BaseModel):

trading212/trading212.py

@@ -353,7 +353,7 @@ def fetch_specific_position(self, ticker: str) -> Position:
 
         return Position(**response)
 
-    def historical_order_data(self, cursor: int, ticker: str, limit: int) -> HistoricalOrderData:
+    def historical_order_data(self, cursor: int | None = None, ticker: str | None = None, limit: int = None) -> HistoricalOrderData:
         """Fetch historical order data
 
         https://t212public-api-docs.redoc.ly/#operation/orders_1
@@ -367,14 +367,11 @@ def historical_order_data(self, cursor: int, ticker: str, limit: int) -> Histori
             HistoricalOrderData: _description_
         """
         endpoint = self.url + "equity/history/orders"
-        params = None
-        if cursor or ticker or limit:
-            params = {
-                "cursor": cursor,
-                "ticker": ticker,
-                "limit": limit
-            }
-        response = self._get(endpoint, params)
+        response = self._get(endpoint, {
+            "cursor": cursor,
+            "ticker": ticker,
+            "limit": limit
+        })
 
         return HistoricalOrderData(**response)