Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

same names in profiles and history #5

Open
fherwig opened this issue Nov 26, 2017 · 1 comment
Open

same names in profiles and history #5

fherwig opened this issue Nov 26, 2017 · 1 comment
Assignees

Comments

@fherwig
Copy link
Contributor

fherwig commented Nov 26, 2017

It is possible to select quantities which have the same names, such as logL to be names in profiles and history output, leading nugridse (and probably other tools) to get confused when trying to extract quantities.

Workaround:
Find doubles in cattrs and dcols:

for otherthing in see.se.cattrs:
    [print(thing) for thing in see.se.dcols if otherthing in thing]

and make sure by hand that no name appears in both history_columns.list and profiles_columns.list.

However, the proper solution would be

  1. MESA should not use the same name for different things.
  2. Since we may not be able to change that immediately, mesa_h5 should check that same-named quantities can not be selected, stop the execution with a meaningful warning with clear instructions on what to do. Alternatively the names could be changed if the change_names="True" flag is set.
@jcpassy
Copy link
Owner

jcpassy commented Oct 26, 2018

1- I agree
2- Don't you think that is should be handled by nugridse rather than by mesa_h5?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants