-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
markdown fixes, html tweaks, and two emoji consistency fixes #74
Conversation
gonna make this up-to-date soon |
I also realize that it might be better for me to separate this pr into two prs, one for the general fixes and another for the emoji tweaks. Should I do that? @jdecked |
activity going well it seems |
I understand that having a PR sit for a while is frustrating. Committing one mega-PR that changes 47 files with a combo of explained, unexplained, and linting preference changes is not an efficient way to contribute to OSS (or, really, to most projects used by many people). Generally PRs like these go to the bottom of most OSS maintainers' to-do lists because reviewing them takes much more coaching/feedback than the average maintainer has time for, even if the changes themselves aren't complicated: you're effectively handing the maintainer a pile of coloured bricks and asking them to sort the bricks for you before adding them to the building. Some OSS projects have the bandwidth to coach people into making higher efficiency contributions, but not all (or even most). Twemoji typically follows a once a year release cadence in line with Unicode – typically with a few patches in between. We often batch the "please redesign XYZ emoji" issue requests into one patch or (less frequently) the next minor/major release. Patches come out when we have time for non-critical issues: unlike some other OSS projects, Twemoji isn't anyone's day job. Now that I've explained this to you, hopefully you realize the sarcasm wasn't necessary. |
I do wish there was an acknowledgement of this pr but it wasn't a reason for me to be sassy about it. sorry about that. I'll close this pr and split it into one for markdown and one for the actual emoji changes at some point in the future. I don't understand why the new emojis were written to by the github action in commit 94c7591 when I pulled from the upstream. hopefully that won't happen next time when I fork it from the upstream originally. again, really sorry for the sarcasm, and thank you for doing god's work with this project. |
Most notable non-emoji changes:
master
withmain
yarn prepublish
isn't a command, butyarn prepublishOnly
wasgit clone -b master {repo}
was shortened togit clone {repo}
(again,master
doesn't exist)var
s tolet
sEmoji changes:
:imp:
(\u1f47f
) are now consistent with that of:smiling-imp:
(\u1f608
)Running
yarn prepublishOnly
didn't prompt me to change the version number, otherwise I would have made it15.2.1
Last thing: I had to install jq with brew in order to even use that yarn command, so should I put add it as an extra step for macOS users in CONTRIBUTING.md?