We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is there a reason why you chose Importer->addRow method as private?
Importer->addRow
In my business case I need to overwrite Importer->addRow method (I need to check if row already exists & don't import duplicates).
By overriding service I managed to do everything, but I had to create new method & duplicate Importer->import to call new method.
Importer->import
It would be a lot easier if I could just overwrite addRow method.
If you agree - I could do PR.
Or maybe it should be handled by adding avro_csv.before_row_add event? (extending functionality to support it).
avro_csv.before_row_add
Waiting for your thoughts.
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Is there a reason why you chose
Importer->addRow
method as private?In my business case I need to overwrite
Importer->addRow
method (I need to check if row already exists & don't import duplicates).By overriding service I managed to do everything, but I had to create new method & duplicate
Importer->import
to call new method.It would be a lot easier if I could just overwrite addRow method.
If you agree - I could do PR.
Or maybe it should be handled by adding
avro_csv.before_row_add
event? (extending functionality to support it).Waiting for your thoughts.
The text was updated successfully, but these errors were encountered: