Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS inconsistencies with inline translation from text selection #74

Open
tobozo opened this issue Aug 27, 2023 · 0 comments
Open

CSS inconsistencies with inline translation from text selection #74

tobozo opened this issue Aug 27, 2023 · 0 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@tobozo
Copy link

tobozo commented Aug 27, 2023

Hi and thanks for that great project 👍

Problem:

In certain conditions (e.g. with general directive body { color: #fff }), the translated text may appear as white text on white background.

Possible cause:

The .translation area created to hold the translated text has a css directive font-color: inherit but the parent element does not specify any font-color directive.

image

As a result the translation area inherits its font-color from outside the web-extension context.

https://github.com/jelmervdl/translatelocally-web-ext/blob/main/src/content/SelectionTranslation.css#L27

[edit] Actually the parent element #x-bergamot-translation-popup specifies a css background-color value whereas it should also inherit.

@jelmervdl jelmervdl self-assigned this Feb 18, 2024
@jelmervdl jelmervdl added bug Something isn't working good first issue Good for newcomers labels Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants