Adapt to removal of built-in executor config from global system configuration (#2211)

Co-authored-by: Tim Jacomb <[email protected]>

Author: janfaracik

src/main/java/org/jenkinsci/test/acceptance/po/JenkinsConfig.java

@@ -11,9 +11,7 @@
 public class JenkinsConfig extends ConfigurablePageObject {
     public final Jenkins jenkins;
 
-    public final Control numExecutors = control("/jenkins-model-MasterBuildConfiguration/numExecutors");
-
-    public final Control labels = control("/jenkins-model-MasterBuildConfiguration/labelString");
+    public final Control quietPeriod = control("/jenkins-model-GlobalQuietPeriodConfiguration/quietPeriod");
 
     public JenkinsConfig(Jenkins jenkins) {
         super(jenkins.injector, jenkins.url("configure"));
@@ -45,7 +43,7 @@ public void setShell(String path) {
     }
 
     public void setQuietPeriod(int seconds) {
-        control("/jenkins-model-GlobalQuietPeriodConfiguration/quietPeriod").set(seconds);
+        quietPeriod.set(seconds);
     }
 
     public void setDescription(String desc) {

src/test/java/core/FormValidationTest.java

@@ -60,16 +60,16 @@ private void ajaxValidation() {
     private void jsValidation() {
         JenkinsConfig c = jenkins.getConfigPage();
         c.configure();
-        c.numExecutors.set(16);
-        FormValidation formValidation = c.numExecutors.getSilentFormValidation();
+        c.setQuietPeriod(16);
+        FormValidation formValidation = c.quietPeriod.getSilentFormValidation();
         assertThat(formValidation, silent());
 
-        c.numExecutors.set(-16);
-        c.numExecutors.resolve().sendKeys(Keys.TAB);
-        c.numExecutors.sleep(100L);
-        formValidation = c.numExecutors.getFormValidation();
+        c.setQuietPeriod(-16);
+        c.quietPeriod.resolve().sendKeys(Keys.TAB);
+        c.quietPeriod.sleep(100L);
+        formValidation = c.quietPeriod.getFormValidation();
 
-        String errorMessage = "Not a non-negative integer";
+        String errorMessage = "This value should be larger than 0";
         assertThat(formValidation, reports(Kind.ERROR, errorMessage));
     }
 

src/test/java/plugins/PrioritySorterPluginTest.java

@@ -112,7 +112,7 @@ public void saving_global_config_should_not_create_job_change() {
 
         final JenkinsConfig global = jenkins.getConfigPage();
         global.configure();
-        global.numExecutors.set(42);
+        global.setDescription("Testing");
         global.save();
 
         assertThat(action.getChanges().size(), equalTo(expected));