Remove override of `hpi-plugin.version` for Launchable

[jglick]

Currently prep.sh is using an old unofficial Incremental build of the mojo, making for manual work such as #5543 (comment).

bom/prep.sh

Line 41 in 345eb51

-Dhpi-plugin.version=3.1749.v2ce5383a_7f9a_ \

should be removed by either merging jenkinsci/maven-hpi-plugin#464 and using an official release version, or not using Launchable.

[Siddd-hrr]

hii, @jglick I would like to work on this .
Suggested Solution :- removing the line from the code

bom/prep.sh

Line 41 in 345eb51

-Dhpi-plugin.version=3.1749.v2ce5383a_7f9a_ \

It will remove the override and start using an official version , according to me it should work fine ?

[jglick]

No, the reason the override was there is that the official versions do not include the option which is currently being used.

[Siddd-hrr]

Hello @jglick I have proposed a new solution , tried to remove the override of launchable and let it work on latest hpi-plugin version.

Honestly I don't know whether I am thinking in correct direction about the logic in the code , but I have tried if am going wrong please let me know ?

[jglick]

No, someone familiar with the Launchable usage in this component will need to work on it.

[daniel-beck]

Looks like this incremental is now expired (however that works): https://repo.jenkins-ci.org/incrementals/org/jenkins-ci/tools/maven-hpi-plugin/ + https://ci.jenkins.io/job/Tools/job/bom/job/PR-5952/7/console

[timja]

@MarkEWaite / @jglick do we need launchable in this component?

It was added in: #1918

[dduportal]

Looks like this incremental is now expired (however that works): https://repo.jenkins-ci.org/incrementals/org/jenkins-ci/tools/maven-hpi-plugin/ + https://ci.jenkins.io/job/Tools/job/bom/job/PR-5952/7/console

Yup, jenkins-infra/helpdesk#4538 for context about the 90-days window cleanup in Artifactory

[MarkEWaite]

@MarkEWaite / @jglick do we need launchable in this component?

It was added in: #1918

I'm not using Launchable in this repository. I use it for Jenkins core, but not here.

[jglick]

I'm not using Launchable in this repository.

If Launchable is not being used here, then jenkinsci/maven-hpi-plugin#464 may be closed and #1918 at least partly reverted (the override deleted, and all references to Launchable deleted)?

[timja]

Agreed lets do that.