use pattern variables

Author: mawinter69

src/main/java/io/jenkins/plugins/agent_build_history/AgentBuildHistory.java

@@ -165,8 +165,8 @@ public static AgentExecution loadSingleExecution(String jobName, int buildNumber
     LOGGER.finer("Loading run " + run.getFullDisplayName());
     AgentExecution execution = new AgentExecution(run);
 
-    if (run instanceof AbstractBuild) {
-      Node node = ((AbstractBuild<?, ?>) run).getBuiltOn();
+    if (run instanceof AbstractBuild<?, ?> build) {
+      Node node = build.getBuiltOn();
       if (node != null) {
         LOGGER.finer("Loading AbstractBuild on node: " + node.getNodeName());
         return execution;
@@ -212,13 +212,12 @@ private static void load() {
     runList.forEach(run -> {
       LOGGER.finer("Loading run " + run.getFullDisplayName());
 
-      if (run instanceof AbstractBuild) {
-        Node node = ((AbstractBuild<?, ?>) run).getBuiltOn();
+      if (run instanceof AbstractBuild<?, ?> build) {
+        Node node = build.getBuiltOn();
         if (node != null) {
           BuildHistoryFileManager.addRunToNodeIndex(node.getNodeName(), run, AgentBuildHistoryConfig.get().getStorageDir());
         }
-      } else if (run instanceof WorkflowRun) {
-        WorkflowRun wfr = (WorkflowRun) run;
+      } else if (run instanceof WorkflowRun wfr) {
         FlowExecution flowExecution = wfr.getExecution();
         if (flowExecution != null) {
           for (FlowNode flowNode : new DepthFirstScanner().allNodes(flowExecution)) {

src/main/java/io/jenkins/plugins/agent_build_history/AgentBuildHistoryListeners.java

@@ -41,9 +41,8 @@ public static class HistoryItemListener extends ItemListener {
 
     @Override
     public void onDeleted(Item item) {
-      if (item instanceof Job) {
-        Job<?, ?> job = (Job<?, ?>) item;
-        String jobName = job.getFullName();
+      if (item instanceof Job<?, ?>) {
+        String jobName = item.getFullName();
         BuildHistoryFileManager.deleteJobSerialization(jobName, AgentBuildHistoryConfig.get().getStorageDir());
       }
     }
@@ -84,18 +83,15 @@ public static class AgentBuildHistoryExecutorListener implements ExecutorListene
     public void taskStarted(Executor executor, Queue.Task task) {
       Queue.Executable executable = executor.getCurrentExecutable();
       Computer c = executor.getOwner();
-      if (executable instanceof AbstractBuild) {
-        Run<?, ?> run = (Run<?, ?>) executable;
+      if (executable instanceof Run<?, ?> run) {
         LOGGER.log(Level.FINER, () -> "Starting Job: " + run.getFullDisplayName() + " on " + c.getName());
         AgentBuildHistory.startJobExecution(c, run);
-      } else if (task instanceof ExecutorStepExecution.PlaceholderTask) {
-        ExecutorStepExecution.PlaceholderTask pht = (ExecutorStepExecution.PlaceholderTask) task;
+      } else if (task instanceof ExecutorStepExecution.PlaceholderTask pht) {
         executable = task.getOwnerExecutable();
         try {
           FlowNode node = pht.getNode();
-          if (node != null && executable instanceof WorkflowRun) {
-            Run<?, ?> run = (Run<?, ?>) executable;
-            AgentBuildHistory.startFlowNodeExecution(c, (WorkflowRun) run, node);
+          if (node != null && executable instanceof WorkflowRun run) {
+            AgentBuildHistory.startFlowNodeExecution(c, run, node);
             LOGGER.log(Level.FINER, () -> "Starting part of pipeline: " + run.getFullDisplayName()
                 + " Node id: " + node.getId() + " on " + c.getName());
           }

src/main/java/io/jenkins/plugins/agent_build_history/AgentExecution.java

@@ -115,8 +115,8 @@ private FlowNode getEndNode() {
       if (execution != null) {
         try {
           FlowNode node = execution.getNode(nodeId);
-          if (node instanceof BlockStartNode) {
-            return ((BlockStartNode) node).getEndNode();
+          if (node instanceof BlockStartNode bsn) {
+            return bsn.getEndNode();
           }
         } catch (IOException e) {
           return null;
@@ -180,18 +180,17 @@ public Status getFlowNodeStatus() {
       }
       if (status == null) {
         Run<?, ?> run = AgentExecution.this.getRun();
-        if (!(run instanceof WorkflowRun)) {
+        if (!(run instanceof WorkflowRun wfr)) {
           return Status.UNKNOWN;
         }
-        WorkflowRun wfr = (WorkflowRun) run;
         FlowExecution flowExecution = wfr.getExecution();
         if (flowExecution == null) {
           return Status.UNKNOWN;
         }
         try {
           FlowNode node = flowExecution.getNode(nodeId);
-          if (node instanceof BlockStartNode) {
-            BlockEndNode<?> endNode = ((BlockStartNode) node).getEndNode();
+          if (node instanceof BlockStartNode bsn) {
+            BlockEndNode<?> endNode = bsn.getEndNode();
             if (endNode != null) {
               ErrorAction errorAction = endNode.getError();
               status = errorAction != null ? Status.FAILURE : Status.SUCCESS;