Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sonar violations are commented with 'unresolved' status #127

Open
spyken7 opened this issue Oct 28, 2022 · 3 comments
Open

Sonar violations are commented with 'unresolved' status #127

spyken7 opened this issue Oct 28, 2022 · 3 comments

Comments

@spyken7
Copy link

spyken7 commented Oct 28, 2022

What feature do you want to see added?

Hello,

We recently upgrade Sonar Gerrit plugin from 2.4.6 to 376.v67dc39df1298.

We noticed that sonar was making "Resolved" comments in grey in the previous version, but it is making "Unresolved" comments in yellow background.

Could you make an option to select the status of the comment?

Thanks!,

Upstream changes

No response

@reda-alaoui
Copy link
Contributor

Hello,

If I understand correctly, you want the comments to be created resolved ?
The behaviour did change. Creating comment resolved was a bug that appeared with latest Gerrit versions.

So you want an option to enable the old bug :)

Feel free to open a pull request

@baocvcv
Copy link

baocvcv commented Nov 13, 2023

Hello,

Is it possible to mark INFO level message from Sonar as resolved, but keep messages above INFO level as unresolved comments?

Thanks!

@reda-alaoui
Copy link
Contributor

@baocvcv , I think you can imagine that there is no possible consensus on the rule you suggest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants