Skip to content

Commit 692225c

Browse files
committed
StashBuildTrigger: Rename StashBuildTriggerDescriptor to DescriptorImpl
DescriptorImpl is the standard name for a descriptor defined as an inner class. StashBuildTriggerDescriptor is a long name that duplicates the name of its containing class, StashBuildTrigger.
1 parent d56749e commit 692225c

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashBuildTrigger.java

+3-4
Original file line numberDiff line numberDiff line change
@@ -55,8 +55,7 @@ public class StashBuildTrigger extends Trigger<Job<?, ?>> {
5555

5656
private transient StashPullRequestsBuilder stashPullRequestsBuilder;
5757

58-
@Extension
59-
public static final StashBuildTriggerDescriptor descriptor = new StashBuildTriggerDescriptor();
58+
@Extension public static final DescriptorImpl descriptor = new DescriptorImpl();
6059

6160
@DataBoundConstructor
6261
public StashBuildTrigger(
@@ -229,8 +228,8 @@ public boolean getOnlyBuildOnComment() {
229228
return onlyBuildOnComment;
230229
}
231230

232-
public static final class StashBuildTriggerDescriptor extends TriggerDescriptor {
233-
public StashBuildTriggerDescriptor() {
231+
public static final class DescriptorImpl extends TriggerDescriptor {
232+
public DescriptorImpl() {
234233
load();
235234
}
236235

src/test/java/stashpullrequestbuilder/stashpullrequestbuilder/StashBuildTriggerTest.java

+1-2
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
import org.mockito.junit.MockitoJUnitRunner;
1515
import org.mockito.junit.MockitoRule;
1616
import org.mockito.quality.Strictness;
17-
import stashpullrequestbuilder.stashpullrequestbuilder.StashBuildTrigger.StashBuildTriggerDescriptor;
1817

1918
@RunWith(MockitoJUnitRunner.class)
2019
public class StashBuildTriggerTest {
@@ -24,7 +23,7 @@ public class StashBuildTriggerTest {
2423

2524
@Test
2625
public void check_getters() throws Exception {
27-
StashBuildTriggerDescriptor descriptor = StashBuildTrigger.descriptor;
26+
StashBuildTrigger.DescriptorImpl descriptor = StashBuildTrigger.descriptor;
2827

2928
// Field names from config.jelly
3029
Iterable<String> properties =

0 commit comments

Comments
 (0)