-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect AP gain for probeType 2013 (4 shank 2.0)? #3
Comments
Yes, the gain changed between the test and commercial versions. I need to update the Datafile tools, thank you for the reminder!
From: Divyansh Gupta ***@***.***>
Sent: Tuesday, December 12, 2023 12:41 PM
To: jenniferColonell/SpikeGLX_Datafile_Tools ***@***.***>
Cc: Subscribed ***@***.***>
Subject: [jenniferColonell/SpikeGLX_Datafile_Tools] Incorrect AP gain for probeType 2013 (4 shank 2.0)? (Issue #3)
External Email: Use Caution
The AP gain for 2.0 probes is hardcoded here<https://urldefense.com/v3/__https:/github.com/jenniferColonell/SpikeGLX_Datafile_Tools/blob/4b6c28658b715808e4941e43d5fa0c57198b09da/Python/DemoReadSGLXData/readSGLX.py*L166C18-L166C18__;Iw!!Eh6p8Q!CFtcZnpEZF80EUbb8Muu3O0voXNl930hdSPDtrawc5VG5f0kKc5HJ0mQMrDeMt_CRGl9ASoaDyaiRQvaxwJOA0VacRTotg$> to be 80 for probe types 21 and 24. However, the manual for commercial 2.0 says the Gain is 100, and I also see that imChan0apGain=100 in my recordings with imDatPrb_type=2013.
Did the gain change between the test and commercial versions?
—
Reply to this email directly, view it on GitHub<https://urldefense.com/v3/__https:/github.com/jenniferColonell/SpikeGLX_Datafile_Tools/issues/3__;!!Eh6p8Q!CFtcZnpEZF80EUbb8Muu3O0voXNl930hdSPDtrawc5VG5f0kKc5HJ0mQMrDeMt_CRGl9ASoaDyaiRQvaxwJOA0UGDUHi1A$>, or unsubscribe<https://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AGVNOX335ON5PCIHJN4D3M3YJCJMFAVCNFSM6AAAAABAR3Q5ROVHI2DSMVQWIX3LMV43ASLTON2WKOZSGAZTQMRWGQZDQNY__;!!Eh6p8Q!CFtcZnpEZF80EUbb8Muu3O0voXNl930hdSPDtrawc5VG5f0kKc5HJ0mQMrDeMt_CRGl9ASoaDyaiRQvaxwJOA0XouHEDFQ$>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.******@***.***>>
|
Thanks for the quick reply! Is it safe to rely on |
Yes, for any new data, you can use that metadata item. I’ll add that to Datafile tools, too – but I also need to keep them backward compatible.
From: Divyansh Gupta ***@***.***>
Sent: Tuesday, December 12, 2023 1:23 PM
To: jenniferColonell/SpikeGLX_Datafile_Tools ***@***.***>
Cc: Colonell, Jennifer ***@***.***>; Comment ***@***.***>
Subject: Re: [jenniferColonell/SpikeGLX_Datafile_Tools] Incorrect AP gain for probeType 2013 (4 shank 2.0)? (Issue #3)
External Email: Use Caution
Thanks for the quick reply!
Is it safe to rely on meta['imChan0apGain'] across 2.0 probe types? I'm fixing a similar issue in spikeinterface/neo <https://urldefense.com/v3/__https:/github.com/NeuralEnsemble/python-neo/pull/1363*issuecomment-1852564877__;Iw!!Eh6p8Q!GlVxJgIGq5UwEFqPRYfgHxbn9mfcnhAhDjjXDdCB05fUli9viDDcDJmLB82JleIfnBi6dN70SI8zXSM4ZfTDP2SUX3ROLQ$>
—
Reply to this email directly, view it on GitHub<https://urldefense.com/v3/__https:/github.com/jenniferColonell/SpikeGLX_Datafile_Tools/issues/3*issuecomment-1852578727__;Iw!!Eh6p8Q!GlVxJgIGq5UwEFqPRYfgHxbn9mfcnhAhDjjXDdCB05fUli9viDDcDJmLB82JleIfnBi6dN70SI8zXSM4ZfTDP2R5GUuExg$>, or unsubscribe<https://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AGVNOX5PZIEBZRJEUBMEHUTYJCOIFAVCNFSM6AAAAABAR3Q5ROVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJSGU3TQNZSG4__;!!Eh6p8Q!GlVxJgIGq5UwEFqPRYfgHxbn9mfcnhAhDjjXDdCB05fUli9viDDcDJmLB82JleIfnBi6dN70SI8zXSM4ZfTDP2RHF_Lg_w$>.
You are receiving this because you commented.Message ID: ***@***.******@***.***>>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The AP gain for 2.0 probes is hardcoded here to be 80 for probe types 21 and 24. However, the manual for commercial 2.0 says the Gain is 100, and I also see that
imChan0apGain=100
in my recordings withimDatPrb_type=2013
.Did the gain change between the test and commercial versions?
The text was updated successfully, but these errors were encountered: