Handles PHP8.4 nullable type deprecations

Author: nyamsprod

.php-cs-fixer.php

@@ -29,6 +29,7 @@
         ],
         'no_trailing_comma_in_singleline' => true,
         'no_unused_imports' => true,
+        'nullable_type_declaration_for_default_null_value' => true,
         'ordered_imports' => ['imports_order' => ['class', 'function', 'const'], 'sort_algorithm' => 'alpha'],
         'phpdoc_add_missing_param_annotation' => ['only_untyped' => true],
         'phpdoc_align' => true,

composer.json

@@ -46,16 +46,16 @@
         "ext-json": "*"
     },
     "require-dev": {
-        "friendsofphp/php-cs-fixer": "^v3.35.1",
-        "guzzlehttp/guzzle": "^7.8",
-        "guzzlehttp/psr7": "^1.6 || ^2.6.1",
-        "phpstan/phpstan": "^1.10.39",
-        "phpstan/phpstan-phpunit": "^1.3.15",
-        "phpstan/phpstan-strict-rules": "^1.5.1",
-        "phpunit/phpunit": "^10.4.1",
+        "friendsofphp/php-cs-fixer": "^3.52.1",
+        "guzzlehttp/guzzle": "^7.8.1",
+        "guzzlehttp/psr7": "^1.6 || ^2.6.2",
+        "phpstan/phpstan": "^1.10.64",
+        "phpstan/phpstan-phpunit": "^1.3.16",
+        "phpstan/phpstan-strict-rules": "^1.5.2",
+        "phpunit/phpunit": "^10.5.15",
         "psr/http-factory": "^1.0.2",
         "psr/simple-cache": "^1.0.1",
-        "symfony/cache": "^v5.0.0 || ^v6.3.5"
+        "symfony/cache": "^v5.0.0 || ^6.4.4"
     },
     "suggest": {
         "psr/http-client-implementation": "To use the storage functionnality which depends on PSR-18",

src/Domain.php

@@ -86,7 +86,7 @@ public function label(int $key): ?string
     /**
      * @return list<int>
      */
-    public function keys(string $label = null): array
+    public function keys(?string $label = null): array
     {
         return $this->registeredName->keys($label);
     }
@@ -155,7 +155,7 @@ public function clear(): self
     /**
      * @throws CannotProcessHost
      */
-    public function slice(int $offset, int $length = null): self
+    public function slice(int $offset, ?int $length = null): self
     {
         return $this->newInstance($this->registeredName->slice($offset, $length));
     }

src/DomainName.php

@@ -49,7 +49,7 @@ public function labels(): array;
      *
      * @return list<int>
      */
-    public function keys(string $label = null): array;
+    public function keys(?string $label = null): array;
 
     /**
      * The external iterator iterates over the DomainInterface labels
@@ -119,5 +119,5 @@ public function clear(): self;
      *
      * If $length is null it returns all elements from $offset to the end of the Domain.
      */
-    public function slice(int $offset, int $length = null): self;
+    public function slice(int $offset, ?int $length = null): self;
 }

src/RegisteredName.php

@@ -190,7 +190,7 @@ public function label(int $key): ?string
     /**
      * @return list<int>
      */
-    public function keys(string $label = null): array
+    public function keys(?string $label = null): array
     {
         if (null === $label) {
             return array_keys($this->labels);
@@ -345,7 +345,7 @@ public function clear(): self
     /**
      * @throws CannotProcessHost
      */
-    public function slice(int $offset, int $length = null): self
+    public function slice(int $offset, ?int $length = null): self
     {
         $nbLabels = count($this->labels);
         if ($offset < - $nbLabels || $offset > $nbLabels) {

src/ResolvedDomainTest.php

@@ -236,7 +236,7 @@ public static function toAsciiProvider(): iterable
     }
 
     #[DataProvider('withSubDomainWorksProvider')]
-    public function testItCanHaveItsSubDomainChanged(ResolvedDomain $domain, DomainName|string|null $subdomain, string $expected = null): void
+    public function testItCanHaveItsSubDomainChanged(ResolvedDomain $domain, DomainName|string|null $subdomain, ?string $expected = null): void
     {
         $result = $domain->withSubDomain($subdomain);
 

src/UnableToLoadTopLevelDomainList.php

@@ -9,7 +9,7 @@
 
 final class UnableToLoadTopLevelDomainList extends InvalidArgumentException implements CannotProcessHost
 {
-    public static function dueToInvalidTopLevelDomain(string $content, Throwable $exception = null): self
+    public static function dueToInvalidTopLevelDomain(string $content, ?Throwable $exception = null): self
     {
         return new self('Invalid Top Level Domain: '.$content, 0, $exception);
     }