Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: vulnz Docker #87

Closed
wants to merge 6 commits into from
Closed

feat: vulnz Docker #87

wants to merge 6 commits into from

Conversation

derhecht
Copy link
Contributor


java -jar /usr/local/bin/vulnz cve --cache --directory $CACHE_DIR
cd $CACHE_DIR || (echo "$CACHE_DIR not found - could not zip cve files\!" && exit 1)
for file in *.json; do gzip -k "${file}"; done

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this step still required? in 5.0.3 the output is produced already gzip'ed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if so, of course not. i will update.

@jeremylong
Copy link
Owner

this PR is part of the plan - I just want to stabilize things before merging this one.

@EugenMayer
Copy link
Contributor

Jumping in to help with the review. Thank you for putting all the hard work into dockerizing it.

I would love to build a helm chart out of this similar to the one i published for the old nist json api over at https://github.com/EugenMayer/helm-charts/tree/main/charts/nist-data-mirror

The docker container looks fine, nearly rootless and AFAICS the NVD_API_KEY is already ENV based - so it is all set to go.
I would tend to use a

  • non privileged port for apache, but well, since it drops the permission, but well, we could go full rootless by just doing that or maybe just using nginx which supports rootless officially.
  • add a VOLUME /usr/local/apache2/htdocs statement since we want a little more 'persistence' out of it

Anyway, for me those are minors, the PR looks good already.

I would add the usage on how to start the docker container in the README and including the hint with the ENV based API key

For example

docker run -v cache:/usr/local/apache2/htdocs -e NVD_API_KEY=myapikey ghcr.io/jeremylong/vuln
# run the update manually
docker run -v cache:/usr/local/apache2/htdocs -e NVD_API_KEY=myapikey ghcr.io/jeremylong/vuln java -jar /usr/local/bin/vulnz cve --cache --directory /usr/local/apache2/htdocs

@EugenMayer EugenMayer mentioned this pull request Dec 16, 2023
4 tasks
@EugenMayer
Copy link
Contributor

created #114 to adjust, upstream merge, add docs (since i cannot contribute on this PR). Used this PR as the base.

@jeremylong
Copy link
Owner

@derhecht thank you for the PR. I'm sorry this has taken me so long to get to. We will be continuing with #114.

@jeremylong jeremylong closed this Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants