Skip to content

Commit 4594368

Browse files
committed
Upgrade to latest Intercom SDK and resolve GCM crashing with custom hook
1 parent cfb9bf7 commit 4594368

40 files changed

+224
-321
lines changed

.classpath

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,16 @@
55
<classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER"/>
66
<classpathentry kind="lib" path="/Applications/Android/platforms/android-23/android.jar"/>
77
<classpathentry kind="lib" path="/Applications/Android/add-ons/addon-google_apis-google-23/libs/maps.jar"/>
8-
<classpathentry kind="lib" path="/Users/jerodfritz/Library/Application Support/Titanium/mobilesdk/osx/5.1.1.GA/android/titanium.jar"/>
9-
<classpathentry kind="lib" path="/Users/jerodfritz/Library/Application Support/Titanium/mobilesdk/osx/5.1.1.GA/android/kroll-common.jar"/>
10-
<classpathentry kind="lib" path="/Users/jerodfritz/Library/Application Support/Titanium/mobilesdk/osx/5.1.1.GA/android/kroll-apt.jar"/>
8+
<classpathentry kind="lib" path="/Users/jerodfritz/Library/Application Support/Titanium/mobilesdk/osx/5.2.2.GA/android/titanium.jar"/>
9+
<classpathentry kind="lib" path="/Users/jerodfritz/Library/Application Support/Titanium/mobilesdk/osx/5.2.2.GA/android/kroll-common.jar"/>
10+
<classpathentry kind="lib" path="/Users/jerodfritz/Library/Application Support/Titanium/mobilesdk/osx/5.2.2.GA/android/kroll-apt.jar"/>
1111
<classpathentry kind="src" path=".apt_generated">
1212
<attributes>
1313
<attribute name="optional" value="true"/>
1414
</attributes>
1515
</classpathentry>
16+
<classpathentry kind="lib" path="android/lib/intercom-sdk-base-classes.jar"/>
17+
<classpathentry kind="lib" path="android/lib/repackaged_dependencies.jar"/>
18+
<classpathentry kind="lib" path="android/lib/intercom-sdk-gcm-classes.jar"/>
1619
<classpathentry kind="output" path="bin"/>
1720
</classpath>

CHANGELOG.txt

Lines changed: 0 additions & 1 deletion
This file was deleted.

README.md

Lines changed: 49 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# Intercom android module for Intercom Android SDK version 1.1.11
1+
### Intercom android module for Intercom Android SDK version 1.1.21
22

33
Integrate Intercom.io with Appcelerator. iOS module available here https://github.com/markive/TiIntercom . Tested with 5.1.1GA SDK
44

@@ -47,7 +47,7 @@ exports.setDeviceToken = function(token, appicon /* 'device-token', Ti.App.Andro
4747
4848
```
4949

50-
### tiapp.xml changes for Android GCM support
50+
### IMPORTANT : tiapp.xml changes for Android GCM support
5151
```
5252
<android xmlns:android="http://schemas.android.com/apk/res/android">
5353
<manifest>
@@ -78,6 +78,53 @@ exports.setDeviceToken = function(token, appicon /* 'device-token', Ti.App.Andro
7878
</android>
7979
```
8080

81+
### IMPORTANT : create hooks folder and intercom.js file in the module for Android GCM support
82+
You need to create a hooks folder with a .js file inside the module directory with the following contents. This makes sure the additional R values are added for intercom during compile. If someone can tell me how to update the ant build script to create this automatically in the compiled dist please let me know otherwise you need to do this manually after compile.
83+
84+
Create the following file:
85+
86+
FILE: /modules/android/ti.intercom.android/1.0.4/hooks/intercom.js
87+
```
88+
exports.cliVersion = '>=3.X';
89+
90+
exports.init = function(logger, config, cli, appc) {
91+
cli.on('build.android.aapt', {
92+
pre : function(data, next) {
93+
var args = data.args[1];
94+
if (args.indexOf('--auto-add-overlay') < 0) {
95+
args.push('--auto-add-overlay');
96+
}
97+
98+
var externalLibraries = [{
99+
javaClass : 'io.intercom.android.sdk.gcm',
100+
resPath : '/Users/jerodfritz/Appcelerator/Prspctr/modules/android/ti.intercom.android/1.0.4/platform/android/gcm-res'
101+
}];
102+
console.log("Add Intercom GCM External Libraries", JSON.stringify(externalLibraries));
103+
104+
// --extra-packages can be defined just once
105+
if (args.indexOf('--extra-packages') < 0) {
106+
args.push('--extra-packages');
107+
args.push('');
108+
}
109+
var namespaceIndex = args.indexOf('--extra-packages') + 1;
110+
111+
externalLibraries.forEach(function(lib) {
112+
if (args[namespaceIndex].indexOf(lib.javaClass) < 0) {
113+
args[namespaceIndex].length && (args[namespaceIndex] += ':');
114+
args[namespaceIndex] += lib.javaClass;
115+
}
116+
if (args.indexOf(lib.resPath) < 0) {
117+
args.push('-S');
118+
args.push(lib.resPath);
119+
}
120+
});
121+
next(null, data);
122+
}
123+
});
124+
};
125+
```
126+
127+
81128
#### Author
82129
Jerod
83130

android/LICENSE

Lines changed: 0 additions & 1 deletion
This file was deleted.

android/build.properties

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1-
titanium.platform=/Users/jerodfritz/Library/Application Support/Titanium/mobilesdk/osx/5.1.1.GA/android
1+
titanium.platform=/Users/jerodfritz/Library/Application Support/Titanium/mobilesdk/osx/5.3.0.GA/android
22
android.platform=/Applications/Android/platforms/android-23
33
google.apis=/Applications/Android/add-ons/addon-google_apis-google-23
4+
android.ndk=/Applications/Android/ndk

android/build.xml

Lines changed: 0 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -24,33 +24,6 @@
2424
</condition>
2525
</fail>
2626

27-
<!-- Copy documentation subdirectories -->
28-
<mkdir dir="${basedir}/documentation"/>
29-
<copy todir="${basedir}/documentation">
30-
<fileset dir="${basedir}/../documentation"/>
31-
</copy>
32-
33-
<!-- Copy example subdirectories -->
34-
<mkdir dir="${basedir}/example"/>
35-
<copy todir="${basedir}/example">
36-
<fileset dir="${basedir}/../example"/>
37-
</copy>
38-
39-
<!-- Copy assets subdirectories -->
40-
<mkdir dir="${basedir}/assets"/>
41-
<copy todir="${basedir}/assets">
42-
<fileset dir="${basedir}/../assets"/>
43-
</copy>
44-
45-
<!-- Copy license -->
46-
<copy todir="${basedir}" file="${basedir}/../LICENSE"/>
47-
48-
<target name="cleancopy" description="Delete old copies">
49-
<delete dir="${basedir}/documentation"/>
50-
<delete dir="${basedir}/example"/>
51-
<delete dir="${basedir}/assets"/>
52-
<delete file="${basedir}/LICENSE"/>
53-
</target>
5427

5528
<import file="${titanium.platform}/../module/android/build.xml"/>
5629
</project>
Binary file not shown.
Binary file not shown.

android/dist/tiintercomandroid.jar

115 KB
Binary file not shown.

android/documentation/index.md

Lines changed: 0 additions & 39 deletions
This file was deleted.

android/example/app.js

Lines changed: 0 additions & 39 deletions
This file was deleted.

android/java-sources.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
"/Users/jerodfritz/Documents/Appcelerator_Studio_Workspace/tiintercomandroid/android/src/ti/intercom/android/TiintercomandroidModule.java"

android/lib/README

Lines changed: 0 additions & 2 deletions
This file was deleted.
Binary file not shown.
11.7 KB
Binary file not shown.

android/lib/repackaged_dependencies.jar

100644100755
27.7 KB
Binary file not shown.
Binary file not shown.
4.05 KB
Binary file not shown.
-8.31 KB
Binary file not shown.

android/manifest

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,14 +2,14 @@
22
# this is your module manifest and used by Titanium
33
# during compilation, packaging, distribution, etc.
44
#
5-
version: 1.0.2
5+
version: 1.0.4
66
apiversion: 2
77
architectures: armeabi armeabi-v7a x86
88
description: tiintercomandroid
99
author: Jerod Fritz
1010
license: Specify your license
1111
copyright: Copyright (c) 2015 by Your Company
12-
respackage: io.intercom.android.sdk
12+
respackage: io.intercom.android.sdk
1313

1414
# these should not be edited
1515
name: tiintercomandroid
Binary file not shown.
Binary file not shown.
Loading
Loading
Loading
Loading
Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
<?xml version="1.0" encoding="utf-8"?>
2+
<resources>
3+
<plurals name="intercomsdk_groupMessage">
4+
<item quantity="one">"You have a new message"</item>
5+
<item quantity="other">"You have %d new messages"</item>
6+
</plurals>
7+
<string name="intercomsdk_groupExpandedTitle">New notifications</string>
8+
<string name="intercomsdk_groupTitle">New notifications</string>
9+
<string name="intercomsdk_push_title_format">%1$s from %2$s</string>
10+
</resources>
Loading
Loading
Loading
Loading

android/platform/android/res/values/values.xml

Lines changed: 17 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
<?xml version="1.0" encoding="utf-8"?>
22
<resources xmlns:ns1="http://schemas.android.com/tools">
3-
<!-- From: file:/Users/intercom/Agents/Android/Andy/work/5095e7c558cfdc56/intercom-sdk-base/src/main/res/values/colours.xml -->
4-
<eat-comment/>
53
<color name="intercomsdk_app_name_colour">#009CDE</color>
64
<color name="intercomsdk_attachment_color">#B0BEC5</color>
75
<color name="intercomsdk_background_grey">#eceff1</color>
@@ -25,8 +23,6 @@
2523
<color name="intercomsdk_text_light_black">#455A64</color>
2624
<color name="intercomsdk_white">#FFFFFF</color>
2725
<declare-styleable name="MaxSizeLinearLayout"><attr format="dimension" name="intercomsdk_maxWidth"/><attr format="dimension" name="intercomsdk_maxHeight"/></declare-styleable>
28-
<!-- From: file:/Users/intercom/Agents/Android/Andy/work/5095e7c558cfdc56/intercom-sdk-base/src/main/res/values/dimens.xml -->
29-
<eat-comment/>
3026
<dimen name="intercomsdk_action_item_width">50dp</dimen>
3127
<dimen name="intercomsdk_cell_padding_admin_left">18dp</dimen>
3228
<dimen name="intercomsdk_cell_padding_admin_right">12dp</dimen>
@@ -47,20 +43,18 @@
4743
<dimen name="intercomsdk_rowtime_padding_top">2dp</dimen>
4844
<item format="float" name="intercomsdk_scaled_down_is_typing" type="dimen">0.7</item>
4945
<item format="float" name="intercomsdk_scaled_up_is_typing" type="dimen">1.0</item>
50-
<!-- From: file:/Users/intercom/Agents/Android/Andy/work/5095e7c558cfdc56/intercom-sdk-base/src/main/res/values/plurals.xml -->
51-
<eat-comment/>
5246
<plurals name="intercomsdk_others">
5347
<item quantity="one">" &amp; 1 other"</item>
5448
<item quantity="other">" &amp; %d others"</item>
5549
</plurals>
56-
<!-- From: file:/Users/intercom/Agents/Android/Andy/work/5095e7c558cfdc56/intercom-sdk-base/src/main/res/values/strings.xml -->
57-
<eat-comment/>
5850
<string name="intercomsdk_accessibility_avatar">Avatar</string>
5951
<string name="intercomsdk_accessibility_is_typing">Someone is typing</string>
6052
<string name="intercomsdk_accessibility_powered_by">Powered by Intercom</string>
6153
<string name="intercomsdk_accessibility_shadow">Shadow</string>
6254
<string name="intercomsdk_accessibility_welcome">Welcome message</string>
6355
<string name="intercomsdk_activated_key_message">You\'ve successfully integrated your Android app with the Intercom platform.</string>
56+
<string name="intercomsdk_attachment_cancel">CANCEL</string>
57+
<string name="intercomsdk_attachment_send">SEND</string>
6458
<string name="intercomsdk_close">Close</string>
6559
<string name="intercomsdk_congratulations">Congratulations</string>
6660
<string name="intercomsdk_delivered">Delivered</string>
@@ -78,14 +72,19 @@
7872
<string name="intercomsdk_sending">Sending…</string>
7973
<string name="intercomsdk_sending_failure">Not delivered. Tap to try again.</string>
8074
<string name="intercomsdk_start_new_conversation">Start a conversation…</string>
75+
<string name="intercomsdk_time_day_ago">%dd ago</string>
76+
<string name="intercomsdk_time_hour_ago">%dh ago</string>
77+
<string name="intercomsdk_time_just_now">Just now</string>
78+
<string name="intercomsdk_time_minute_ago">%dm ago</string>
79+
<string name="intercomsdk_time_never">Never</string>
80+
<string name="intercomsdk_time_week_ago">%dw ago</string>
81+
<string name="intercomsdk_time_year_ago">%dy ago</string>
8182
<string name="intercomsdk_title_activity_conversations">Conversations</string>
8283
<string name="intercomsdk_try_again">Tap to try again.</string>
8384
<string name="intercomsdk_twitter_follow">Follow us on Twitter</string>
8485
<string name="intercomsdk_unable_to_load">Unable to load conversations</string>
8586
<string name="intercomsdk_write_a_reply">Write a reply</string>
8687
<string name="intercomsdk_you">You</string>
87-
<!-- From: file:/Users/intercom/Agents/Android/Andy/work/5095e7c558cfdc56/intercom-sdk-base/src/main/res/values/styles.xml -->
88-
<eat-comment/>
8988
<style name="IntercomSDK_AttachmentTheme">
9089
<item name="android:windowIsTranslucent">true</item>
9190
<item name="android:windowNoTitle">true</item>
@@ -102,4 +101,12 @@
102101
<item name="android:windowContentOverlay">@null</item>
103102
<item name="android:windowActionModeOverlay" ns1:ignore="NewApi">true</item>
104103
</style>
104+
<plurals name="intercomsdk_groupMessage">
105+
<item quantity="one">"You have a new message"</item>
106+
<item quantity="other">"You have %d new messages"</item>
107+
</plurals>
108+
<string name="intercomsdk_groupExpandedTitle">New notifications</string>
109+
<string name="intercomsdk_groupTitle">New notifications</string>
110+
<string name="intercomsdk_push_title_format">%1$s from %2$s</string>
111+
105112
</resources>
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
<?xml version="1.0" encoding="utf-8"?>
2+
<resources>
3+
<integer name="google_play_services_version">7571000</integer>
4+
</resources>

0 commit comments

Comments
 (0)