Skip to content

Commit 87e29fc

Browse files
committed
fix: don't include deprecated rules in all config
Resolves #663
1 parent d16b84c commit 87e29fc

File tree

2 files changed

+14
-5
lines changed

2 files changed

+14
-5
lines changed

src/__tests__/rules.test.ts

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,11 @@ import { existsSync } from 'fs';
22
import { resolve } from 'path';
33
import plugin from '../';
44

5-
const ruleNames = Object.keys(plugin.rules);
65
const numberOfRules = 44;
6+
const ruleNames = Object.keys(plugin.rules);
7+
const deprecatedRules = Object.entries(plugin.rules)
8+
.filter(([, rule]) => rule.meta.deprecated)
9+
.map(([name]) => name);
710

811
describe('rules', () => {
912
it('should have a corresponding doc for each rule', () => {
@@ -54,7 +57,7 @@ describe('rules', () => {
5457
'style',
5558
]);
5659
expect(Object.keys(recommendedConfigs.all.rules)).toHaveLength(
57-
ruleNames.length,
60+
ruleNames.length - deprecatedRules.length,
5861
);
5962
const allConfigRules = Object.values(recommendedConfigs)
6063
.map(config => Object.keys(config.rules))

src/index.ts

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -48,9 +48,15 @@ const recommendedRules = Object.entries(rules)
4848
{},
4949
);
5050

51-
const allRules = Object.keys(rules).reduce<
52-
Record<string, TSESLint.Linter.RuleLevel>
53-
>((rules, key) => ({ ...rules, [`jest/${key}`]: 'error' }), {});
51+
const allRules = Object.entries(rules)
52+
// .filter(([, rule]) => !rule.meta.deprecated)
53+
.reduce(
54+
(acc, [name]) => ({
55+
...acc,
56+
[`jest/${name}`]: 'error',
57+
}),
58+
{},
59+
);
5460

5561
const createConfig = (rules: Record<string, TSESLint.Linter.RuleLevel>) => ({
5662
plugins: ['jest'],

0 commit comments

Comments
 (0)