Skip to content

[Bug]: Error running devbox shell in environment with exported Bash function #995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
apgrucza opened this issue May 11, 2023 · 9 comments · May be fixed by #2612
Open

[Bug]: Error running devbox shell in environment with exported Bash function #995

apgrucza opened this issue May 11, 2023 · 9 comments · May be fixed by #2612
Labels
bug Something isn't working

Comments

@apgrucza
Copy link
Contributor

Current Behavior (bug)
To reproduce, run these commands:

foo() { echo foo; }
export -f foo
devbox shell

This error appears:

bash: export: `BASH_FUNC_foo%%=() {  echo foo}': not a valid identifier

Despite the error, the foo function is still available in the shell.

Expected Behavior (fix)
The error should not appear.

Additional context
My devbox version -v:

Version:     0.4.9
Platform:    linux_amd64
Commit:      b03f0d26da3df4318f2a8d70c0531c0c77d0d33c
Commit Time: 2023-05-02T23:26:52Z
Go Version:  go1.20.3
Launcher:    0.2.0
@apgrucza apgrucza added the bug Something isn't working label May 11, 2023
@v3ss0n
Copy link

v3ss0n commented Feb 17, 2024

same here any work around?

@albx79
Copy link

albx79 commented Feb 24, 2024

Apparently, since the exported functions are available inside the devbox environment, the workaround is just to ignore the error.

I'ld still love it for the error not to appear, though, as I wasted quite a bit of time trying to figure out what was wrong with my env.

@Akiyamka
Copy link
Contributor

Akiyamka commented Mar 21, 2024

@albx79 , same thing, I spent about a few hours trying to figure out what went wrong

$ devbox shell
✓ Computed the Devbox environment.
Starting a devbox shell...
/tmp/devbox504213459/.zshrc:export:12: not valid in this context: BASH_FUNC_ml%

For some reason devbox take working function from my env

ml()
{
  eval "$($LMOD_DIR/ml_cmd "$@")"
}

and create this

export BASH_FUNC_ml%%="() {  eval \"\$(\$LMOD_DIR/ml_cmd \"\$@\")\"\
}";

Debug info

$ cat  /tmp/devbox504213459/.zshrc | grep BASH_FUNC_ml%% -B 1 -A 1
export BASH_ENV="/usr/share/lmod/lmod/init/bash";
export BASH_FUNC_ml%%="() {  eval \"\$(\$LMOD_DIR/ml_cmd \"\$@\")\"\
}";

$ zsh --version
zsh 5.9 (x86_64-redhat-linux-gnu)

$ cat /etc/os-release
NAME="Fedora Linux"
VERSION="38 (Workstation Edition)"

$ devbox version
0.10.1

@Akiyamka
Copy link
Contributor

Look like it broke init_hook, it not running anymore

@Akiyamka
Copy link
Contributor

plugins (corepack in my case) fails to execute they hooks too

@Akiyamka
Copy link
Contributor

As I understand this code has this form intentionally, but I still can't figure out how to fix the error
https://antonyt.com/blog/2020-03-27/exploiting-cgi-scripts-with-shellshock

@staylorx
Copy link

When i run devbox shell, I get this,

bash: export: `BASH_FUNC_which%%=() {  ( alias; eval ${which_declare} ) | /usr/bin/which --tty-only --read-alias --read-functions --show-tilde --show-dot $@}': not a valid identifier

It doesn't seem to impact anything -- as other folks above have said, or is it really harmless? -- but it makes it hard for me to convince my team we should use this together.

Is there a flag or variable I can set in the dotenv.json file to bypass parsing or evaluating .bashrc or .bash_profile functions? Or is that misguided... that's part of devbox's charm I suppose when it all works smoothly?

@Akiyamka
Copy link
Contributor

Akiyamka commented Aug 8, 2024

It doesn't seem to impact anything -- as other folks above have said, or is it really harmless?

I already mentioned that it breaks running init scripts. In other words, everything that's written in 

"shell": {  
    "init_hook": [  
        "echo 'This will never executed'"  
     ]  
}  

Not working because of crash

@landtuna
Copy link

For a Red Hat system, this causes problems because of which2.sh, found in /etc/profile.d. A workaround is to put unset which above the call to eval "$(devbox global shellenv)".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging a pull request may close this issue.

6 participants