Skip to content

Commit 3db3178

Browse files
authored
Merge pull request #633 from jetstack/VC-36032-fix-readme-badge
README: badge wasn't showing the latest job run from master
2 parents 4e24a69 + e544700 commit 3db3178

File tree

2 files changed

+17
-8
lines changed

2 files changed

+17
-8
lines changed

.github/workflows/tests.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
name: tests
22
on:
33
push:
4-
branches: [main]
4+
branches: [master]
55
pull_request: {}
66
jobs:
77
verify:

README.md

+16-7
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
[![tests](https://github.com/jetstack/jetstack-secure/actions/workflows/tests.yaml/badge.svg)](https://github.com/jetstack/jetstack-secure/actions/workflows/tests.yaml)
1+
[![tests](https://github.com/jetstack/jetstack-secure/actions/workflows/tests.yaml/badge.svg?branch=master&event=push)](https://github.com/jetstack/jetstack-secure/actions/workflows/tests.yaml)
22
[![Go Reference](https://pkg.go.dev/badge/github.com/jetstack/jetstack-secure.svg)](https://pkg.go.dev/github.com/jetstack/jetstack-secure)
33
[![Go Report Card](https://goreportcard.com/badge/github.com/jetstack/jetstack-secure)](https://goreportcard.com/report/github.com/jetstack/jetstack-secure)
44

@@ -102,26 +102,35 @@ The release process is semi-automated.
102102
> - Create a draft GitHub release,
103103
> - Upload the Helm chart tarball to the GitHub release.
104104
105-
1. Create a tag for the new release:
105+
1. Open the [tests GitHub Actions workflow][tests-workflow]
106+
and verify that it succeeds on the master branch.
107+
2. Run govulncheck:
108+
```bash
109+
go install golang.org/x/vuln/cmd/govulncheck@latest
110+
govulncheck -v ./...
111+
```
112+
3. Create a tag for the new release:
106113
```sh
107114
export VERSION=v1.1.0
108115
git tag --annotate --message="Release ${VERSION}" "${VERSION}"
109116
git push origin "${VERSION}"
110117
```
111-
2. Wait until the GitHub Actions finishes.
112-
3. Navigate to the GitHub Releases page and select the draft release to edit.
118+
4. Wait until the GitHub Actions finishes.
119+
5. Navigate to the GitHub Releases page and select the draft release to edit.
113120
1. Click on “Generate release notes” to automatically compile the changelog.
114121
2. Review and refine the generated notes to ensure they’re clear and useful
115122
for end users.
116123
3. Remove any irrelevant entries, such as “update deps,” “update CI,” “update
117124
docs,” or similar internal changes that do not impact user functionality.
118-
4. Publish the release.
119-
5. Inform the `#venctl` channel that a new version of Venafi Kubernetes Agent has been
125+
6. Publish the release.
126+
7. Inform the `#venctl` channel that a new version of Venafi Kubernetes Agent has been
120127
released. Make sure to share any breaking change that may affect `venctl connect`
121128
or `venctl generate`.
122-
7. Inform Michael McLoughlin of the new release so he can update the
129+
8. Inform Michael McLoughlin of the new release so he can update the
123130
documentation at <https://docs.venafi.cloud/>.
124131

132+
[tests-workflow]: https://github.com/jetstack/jetstack-secure/actions/workflows/tests.yaml?query=branch%3Amaster
133+
125134
> [!NOTE]
126135
>
127136
> For context, the new tag will create the following images:

0 commit comments

Comments
 (0)