-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make jetty-jspc-maven-plugin @threadSafe #6224
Milestone
Comments
@gbo80 I don't anticipate that you will have any threading issues with the jetty-jspc-maven-plugin, but we'll look at adding the appropriate annotation to the plugin. |
olamy
added a commit
that referenced
this issue
May 2, 2021
Signed-off-by: olivier lamy <[email protected]>
Thank you very much! |
olamy
added a commit
that referenced
this issue
May 6, 2021
Signed-off-by: olivier lamy <[email protected]>
olamy
added a commit
that referenced
this issue
May 7, 2021
* Issue #6224 make jspc mojo maven threadsafe Signed-off-by: olivier lamy <[email protected]> * restore previous behaviour Signed-off-by: olivier lamy <[email protected]>
pr merged 04e5c4e |
Can this be re-openned as Jetty 9.4.x still marks it as not-thread-safe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Jetty version
9.x, 10.x, 11.x
Description
Running the jetty-jspc-maven-plugin in a maven build that uses multiple threads (e.g. "mvn -T1C ...") works (so far I found no problems), but I get a warning that the plugin is not @threadSafe.
Question
Do we have to expect problems when running a multi-module project that contains multiple web projects with multiple threads?
We use the JSP precompiler in the maven build only for detecting compilation problems while building.
We do not use the precompiled JSPs in production.
Change request
Please make the plugin @threadSafe.
Thanks
Günther
The text was updated successfully, but these errors were encountered: