Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zoom and pan are buggy #10

Open
alekseyg opened this issue May 10, 2016 · 1 comment
Open

Zoom and pan are buggy #10

alekseyg opened this issue May 10, 2016 · 1 comment
Assignees
Labels

Comments

@alekseyg
Copy link
Contributor

When zooming in, panning, and then zooming out partially, the picture gets stuck with part of it off screen and can't be panned back. This issue appears on all devices I've tested on, but iOS devices have it the worst. The zoom does not return to normal on iOS at all.

Another odd thing is that minimum zoom level allowed. For some reason, it is smaller than the original size of the photo. I think that the minimum zoom level should be either the original size of the photo, or in the case of a large photo, the size of the viewport (like you would get with background-size: contain).

@jfcaiceo jfcaiceo added the bug label May 11, 2016
@jfcaiceo
Copy link
Owner

When zooming in, panning, and then zooming out partially, the picture gets stuck with part of it off screen and can't be panned back

It happens to me only with IOS or safari browser in desktop. I'm going to fix it.

Another odd thing is that minimum zoom level allowed

The minimum zoom is defined by: Math.pow(1 / ZOOM_STEP, 10). With the current ZOOM_STEP, its like 38% of the original photo. I think that in some cases it may be useful to have a min zoom level, but maybe 38% its too much. Let me think about it.

@jfcaiceo jfcaiceo self-assigned this May 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants