Skip to content

Commit e7e7a06

Browse files
committed
nits
Signed-off-by: Jack Cherng <[email protected]>
1 parent 3269ba7 commit e7e7a06

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

general/web_server/compile_php_exts.sh

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ PHP_BASE_DIRS=(
1818
"/usr/local/php80"
1919
)
2020

21+
# the command used to clone a repo
2122
declare -A PHP_EXTS_CMD=(
2223
["apcu"]="git clone https://github.com/krakjoe/apcu.git apcu"
2324
["ast"]="git clone https://github.com/nikic/php-ast.git ast"
@@ -46,6 +47,7 @@ declare -A PHP_EXTS_CHECKOUT=(
4647
["xxhash"]="origin/develop"
4748
)
4849

50+
# extra flags appended to php-config
4951
declare -A PHP_EXTS_CONFIG=(
5052
["jsond"]="--enable-jsond-prefixing"
5153
)
@@ -65,13 +67,13 @@ pushd "${SCRIPT_DIR}" || exit
6567
for IDX in "${!PHP_BASE_DIRS[@]}"; do
6668
PHP_BASE_DIR=${PHP_BASE_DIRS[$IDX]}
6769

68-
# necessary files
70+
# required files
6971
declare -A files=(
7072
["phpize"]="${PHP_BASE_DIR}/bin/phpize"
7173
["php_config"]="${PHP_BASE_DIR}/bin/php-config"
7274
)
7375

74-
# eleminate PHP base directory if necessary files not found
76+
# eleminate PHP base directory if required files not found
7577
for file in "${files[@]}"; do
7678
if [ ! -f "${file}" ]; then
7779
echo "[*] Skip '${PHP_BASE_DIR}' because '${file}' is not a file..."

0 commit comments

Comments
 (0)