Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add terraform examples for aws #1958

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Add terraform examples for aws #1958

merged 1 commit into from
Feb 5, 2025

Conversation

shahiinn
Copy link
Collaborator

Add terraform examples for aws

PR Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version bumped
  • CHANGELOG.md updated
  • Variables and other changes are documented in the README.md
  • Title of the PR starts with chart name (e.g. [artifactory])

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this file

# Setup the required variables

variable "region" {
default = "eu-central-1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to "us-east-1"

@shahiinn shahiinn force-pushed the terraform-examples-1 branch 2 times, most recently from 509c90c to 2cc41ec Compare January 28, 2025 15:16
@shahiinn shahiinn force-pushed the terraform-examples-1 branch 3 times, most recently from b654cab to 5159a9d Compare January 31, 2025 05:30
@eldada
Copy link
Contributor

eldada commented Feb 4, 2025

@shahiinn - can you also rename terraform-examples to just terraform (as it's under the examples directory so no need to duplicate the word examples)

@shahiinn shahiinn force-pushed the terraform-examples-1 branch 2 times, most recently from f24afc7 to 1e0ea50 Compare February 5, 2025 05:30
@shahiinn shahiinn force-pushed the terraform-examples-1 branch from 1e0ea50 to 24bae81 Compare February 5, 2025 08:00
@chukka chukka merged commit eb73063 into master Feb 5, 2025
1 check passed
@chukka chukka deleted the terraform-examples-1 branch February 5, 2025 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants