Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Presets configuration #11877

Open
pascalgrimaud opened this issue Feb 8, 2025 · 3 comments
Open

Improve Presets configuration #11877

pascalgrimaud opened this issue Feb 8, 2025 · 3 comments

Comments

@pascalgrimaud
Copy link
Member

The goal would be to replace the current configuration to something like:

jhlite:
  preset:
    folder: presets/

The presets should load all the JSON in this folder + sub folders instead of reading a single file: preset.json

My idea would be to add to gitignore src/main/resources/presets/perso/

So each user can add their own presets configuration there.

Another improvement would be the possibility to add different preset files:

  • preset-gradle.json
  • preset-maven.json
  • preset-typescript.json

etc

What do you think about this, @renanfranca ?

@renanfranca
Copy link
Contributor

@pascalgrimaud : I like it, and I want to confirm if I understand it correctly. I can implement it after addressing the rank module issue.

My idea would be to add src/main/resources/presets/perso/ to .gitignore.

Did you mean person instead of perso here? So it would be easier to personalize the presets instead of editing the preset.json and having to handle changes made by others, even if the person clones their own fork. Is that right?

Another improvement would be the possibility to add different preset files:

preset-gradle.json
preset-maven.json
preset-typescript.json

So these files would be inside src/main/resources/presets, and the idea is to only put presets related to Gradle in preset-gradle.json and only presets related to Maven in preset-maven.json?

@pascalgrimaud
Copy link
Member Author

Yes you understand well

@renanfranca
Copy link
Contributor

Yes you understand well

Thanks 👍

@renanfranca renanfranca self-assigned this Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants