add sysstat::params class and improve test coverage

manifests/init.pp

@@ -12,7 +12,7 @@
 #
 # Copyright (C) 2013 Joshua Hoblitt
 #
-class sysstat {
+class sysstat inherits sysstat::params {
   class { 'sysstat::install': } ->
   class { 'sysstat::service': } ->
   Class['Sysstat']

manifests/install.pp

@@ -11,7 +11,7 @@
 # Copyright (C) 2013 Joshua Hoblitt
 #
 class sysstat::install {
-  package { 'sysstat':
+  package { $sysstat::params::sysstat_package:
     ensure => present,
   }
 }

manifests/params.pp

@@ -0,0 +1,22 @@
+# == Class: sysstat::params
+#
+# This class should be considered private.
+#
+# === Authors
+#
+# Joshua Hoblitt <[email protected]>
+#
+# === Copyright
+#
+# Copyright (C) 2013 Joshua Hoblitt
+#
+class sysstat::params {
+  case $::osfamily {
+    'redhat': {
+      $sysstat_package = 'sysstat'
+    }
+    default: {
+      fail("Module ${module_name} is not supported on ${::operatingsystem}")
+    }
+  }
+}

spec/classes/sysstat_install_spec.rb

@@ -0,0 +1,19 @@
+require 'spec_helper'
+
+describe 'sysstat::install', :type => :class do
+  let :pre_condition do
+    'include sysstat::params'
+  end
+
+  describe 'for osfamily RedHat' do
+    let :facts do 
+      {
+        :osfamily => 'RedHat',
+      }
+    end
+
+    it { should include_class('sysstat::install') }
+    it { should contain_package('sysstat').with_ensure('present') }
+  end
+
+end

spec/classes/sysstat_params_spec.rb

@@ -0,0 +1,28 @@
+require 'spec_helper'
+
+describe 'sysstat::params', :type => :class do
+  describe 'for osfamily RedHat' do
+    let :facts do
+      {
+        :osfamily => 'RedHat',
+      }
+    end
+
+    it { should include_class('sysstat::params') }
+  end
+
+  describe 'unsupported osfamily' do
+    let :facts do 
+      {
+        :osfamily        => 'Debian',
+        :operatingsystem => 'Debian',
+      }
+    end
+
+    it 'should fail' do
+      expect { should include_class('sysstat::params') }.
+        to raise_error(Puppet::Error, /not supported on Debian/)
+    end
+  end
+
+end

spec/classes/sysstat_service_spec.rb

@@ -0,0 +1,14 @@
+require 'spec_helper'
+
+describe 'sysstat::service', :type => :class do
+
+  it do
+    should contain_service('sysstat').with({
+      :hasstatus  => 'false',
+      :hasrestart => 'true',
+      :enable     => 'true',
+    })
+  end
+
+end
+

spec/classes/sysstat_spec.rb

@@ -1,8 +1,18 @@
 require 'spec_helper'
 
 describe 'sysstat', :type => :class do
-  it { should contain_class('sysstat') }
-  it { should contain_class('sysstat::install') }
-  it { should contain_package('sysstat').with_ensure('present') }
-  it { should contain_class('sysstat::service') }
+
+  describe 'for osfamily RedHat' do
+    let :facts do
+      {
+        :osfamily => 'RedHat',
+      }
+    end
+
+    it { should include_class('sysstat') }
+    it { should include_class('sysstat::params') }
+    it { should include_class('sysstat::install') }
+    it { should include_class('sysstat::service') }
+  end
+
 end