Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings of -Weffc++ #48

Open
jpnurmi opened this issue Feb 28, 2015 · 2 comments
Open

Fix warnings of -Weffc++ #48

jpnurmi opened this issue Feb 28, 2015 · 2 comments

Comments

@jpnurmi
Copy link
Contributor

jpnurmi commented Feb 28, 2015

There are lots of warnings when -Weffc++ is enabled: http://cutebin.fi/pipwgpbvw. The majority of warnings are due to members not being initialized in the initialization list.

Ref. znc/znc#270

@jpnurmi
Copy link
Contributor Author

jpnurmi commented Mar 4, 2015

C++11 delegate constructor would make it easy to get rid of Init(), but is Csocket willing to depend on C++11 yet? If yes, I can prepare a patch.

@jimloco
Copy link
Owner

jimloco commented Mar 4, 2015

Csocket works fine with c++11, but given that it is a library that is used by multiple projects it needs to be able to work without c++11. Making Csocket compliant with -Weffc++ is a nice goal to have and is a reasonable request, but it is definitely low on my list of priorities. However, as time permits I'll address these issues.

Aside from the initialization lists, there are a couple of classes that need copy ctors and assignment operators, and CSocketManager would need to wrap vector<> as opposed to deriving from it. All of which are trivial fixes and just become busy work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants