Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any plans to add Opus support from SharpMP4? #4

Open
bentorkington opened this issue Aug 29, 2024 · 3 comments
Open

Any plans to add Opus support from SharpMP4? #4

bentorkington opened this issue Aug 29, 2024 · 3 comments

Comments

@bentorkington
Copy link
Contributor

I see SharpMP4 has Opus track capability, and that project seems to be more up to date than this one. Is SharpMP4 intended as a replacement for this project and should I use that instead for general MP4 writing?
Thanks

@jimm98y
Copy link
Owner

jimm98y commented Aug 29, 2024

Eventually, yes. SharpMp4Parser is just a port of the Java code base, plus some bug fixes. No new features except for bugfixes are planned.

SharpMp4 is written from the ground up in C#, has better support for newer codecs, is stream in/stream out, but at the moment it is primarily intended and used for fragmented MP4 (fmp4). It is also pretty much work in progress.

Eventually, SharpMP4 will get MP4 support as well, but right now it's not tested on MP4 and when compared to this port it supports fewer MP4 boxes. I had some specific needs for fragmented mp4 that were not met by this project, so I've decided to rewrite everything from the ground up in C# and I've added some new features such as enhanced VPS/PPS/SPS parsers for H265 and as you've noticed also Opus compatibility.

@bentorkington
Copy link
Contributor Author

Thanks. No promises, but if I get a chance to work on Opus I'll put in a PR?

@jimm98y
Copy link
Owner

jimm98y commented Aug 29, 2024

Of course, PRs are welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants