Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed interface_config references #15647

Conversation

laky241
Copy link

@laky241 laky241 commented Feb 20, 2025

Fixes #15633

This PR removes the deprecated interfaceConfig.js file and migrates all its references to config.js.

Deleted interface_config.js

Removed the outdated file that was still being referenced in multiple parts of the codebase.

Replaced occurrences of interfaceConfig with getConfig() from react/features/base/config/functions.ts.

@laky241 laky241 marked this pull request as draft February 20, 2025 18:31
@jitsi-jenkins
Copy link

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

@damencho
Copy link
Member

What will happen for those that use the iframeAPI and are passing interfaceConfigOverwrite and the deployment get updated?

@laky241
Copy link
Author

laky241 commented Feb 21, 2025

You're absolutely right for that I am planning to:

Keep backward compatibility by merging interfaceConfigOverwrite into configOverwrite.

Would love to hear your thoughts on this approach

@damencho
Copy link
Member

I'm not convinced that this is how it needs to happen.
What will happen with all deployments that are still using interface config file for modifications, after the update their modifications will stop working.

Such disruptive changes should go through the community announcements in the forum and The Call and be coordinated by the team.

@laky241
Copy link
Author

laky241 commented Feb 21, 2025

Hey @damencho, that’s a fair point, it makes sense that it should go through community discussions and proper coordination.

I’ll close this PR for now and let the team decide the best approach for deprecating interfaceConfig.js in a way that doesn’t disrupt users.

@laky241 laky241 closed this Feb 21, 2025
@saghul
Copy link
Member

saghul commented Feb 22, 2025

We already have a way to migrate settings in base/config (the reducer).

Basically the usual steps are:

  • Move a setting to config
  • Deprecate it in interface_config
  • Still support reading the old value and internally convert it to the new one
  • Eventually delete the deprecated value and accompanying support code

This is how we've migrated tons of settings already.

Note that the last step needs a long long time since we don't want to break deployments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecated interface_config.js Still Referenced in Build
4 participants