Whiteboard buttons not translated when the first locale in accept-language has no country suffix

[soisik]

What happened?

The i18next module that handles translation of whiteboard UI doesn't seem to handle if short locale without country zone as set as preffered language for website in both chromium or firefox, probably in chrome too but I did not try.

Also because the i18next react module never updates the locale it has previously set in the local storage, changing the preferred locale in the browser settings to include a country code is not enough to bypass this issue, the user also has to clear the local storage of this jitsi instance in his browser dev tools or at least the i18nextLng key that never seems to get updated after first init, private mode or not.

This make reproducing the original problem hard since you have to manually change or clear the key to be able to update the locale.

Steps to reproduce:

• Set your browser language settings to display page in FF or Chrome in locale "fr" first (and not "fr-FR")
• Make sure you have emptied all local storage or at least the key i18nextLng before opening a room in your browser dev tools
• Observe the key i18nextLng being set to "fr" when whiteboard is displayed ;
• The interface of the whiteboard buttons are displayed in english and not in french ;

This steps works to display whiteboard in french:

• Set your browser language settings to display page in Firefox ("Choose your preferred language for displaying pages") or Chrome (Websites in your languages) in locale "fr-FR" first (and not "fr" only )
• Make sure you have emptied all local storage or at least the key i18nextLng before opening a room in your browser dev tools
• Observe the key i18nextLng being set to "fr-FR" when whiteboard is displayed ;
• The browser fetch the asset file /libs/excalidraw-assets/locales/fr-FR-json-e957f763c3571741d176.js containing french translation ;
• The interface of the whiteboard buttons are displayed in in french as expected ;

Also my test did not show any impact on this behaviour when changing server side configuration, such as

• defaultLanguage=en
• LANG_DETECTION=true

Nor its changed anything after changing the user own language in jitsi preferences to french, the whiteboard do not seem to use this settings.

Platform

• Chrome (or Chromium based)
• Firefox
• Safari
• Other desktop browser
• Android browser
• iOS browser
• Electron app
• Android mobile app
• iOS mobile app
• Custom app using a mobile SDK

Browser / app / sdk version

Latest but tried with FF 134.0.2 and chromium Version 133.0.6943.53

Relevant log output

Reproducibility

• The problem is reproducible on meet.jit.si

More details?

After observing this behaviour on our own instances ( one version behind latest) , I tried https://meet.jit.si which has it too.