Transcription UI/ UX improvements, round 2 #14234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saghul
force-pushed
the
transcription-improvements2
branch
from
56c5e1c to
6ca80f0
Compare
saghul
force-pushed
the
transcription-improvements2
branch
from
6ca80f0 to
18f6e60
Compare
It wasn't related to transcriptions but to subtitles, really. Since we are not going to show subtitles just because transcriptions are enabled, this setting no longer makes sense.
saghul
force-pushed
the
transcription-improvements2
branch
from
530556d to
82b56cc
Compare
Both audible and visual. They are only emitted if there is no video recording on.
saghul
force-pushed
the
transcription-improvements2
branch
from
1821c82 to
4f4bbd9
Compare
quitrk
reviewed
Jan 29, 2024
react/features/recording/components/Recording/AbstractStopRecordingDialog.ts
Show resolved
Hide resolved
saghul
force-pushed
the
transcription-improvements2
branch
from
4f4bbd9 to
51e0c41
Compare
|
@quitrk Updated, PTAL! |
quitrk
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.