-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(prejoin) default to enabled #14236
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a2e0524
to
5eb2501
Compare
damencho
previously approved these changes
Jan 16, 2024
Hah this broke the teats for some reason |
I thought we set it to disabled with URL parameters?! |
Nothing in the logs, many screenshots show prejoin so there must be a case where the URL setting is not working ... |
I'll look into it. |
5eb2501
to
831acaa
Compare
damencho
approved these changes
Feb 13, 2024
iospro
pushed a commit
to iospro/jitsi-meet
that referenced
this pull request
Feb 26, 2024
…-audio * develop/custom-24.0: (717 commits) chore(rn, versions): bump app and sdk versions feat(conference/recordin): Fix always on labels (jitsi#14368) chore(deps) lib-jitsi-meet@latest feat(prejoin) default to enabled (jitsi#14236) feat(android): replaced NotificationChannels with NotificationUtils feat(android): update media projection notification build (jitsi#14365) feat(лоббъ): Admin set function for multiple items. feat(android): separate MediaProjection and OngoingConference notifications (jitsi#14363) fix(prejoin) adjust recording warning (jitsi#14361) feat(android): fixed screen sharing for Android 33 (jitsi#14359) fix: Fixes polls parsing. feat(transcript) add ability to dump transcript for debugging fix(whiteboard) handle metadata being null chore(deps) lib-jitsi-meet@latest feat(prejoin) display recording warning (jitsi#14347) feat: Notify jicofo when room_metadata changes the config form. (jitsi#14346) feat(recordings) send recordings metadata code review fix(recording) ensure recording label is shown when transcription is on fix(recording) do not show advanced options for users with local recording rights ... # Conflicts: # android/build.gradle # android/gradle.properties # ios/Podfile.lock # ios/app/broadcast-extension/Info.plist # ios/app/src/Info.plist # ios/app/watchos/app/Info.plist # ios/app/watchos/extension/Info.plist # ios/sdk/src/Info.plist # ios/sdk/src/Lite-Info.plist
iospro
pushed a commit
to iospro/jitsi-meet
that referenced
this pull request
Feb 26, 2024
* develop/custom-24.0: (717 commits) chore(rn, versions): bump app and sdk versions feat(conference/recordin): Fix always on labels (jitsi#14368) chore(deps) lib-jitsi-meet@latest feat(prejoin) default to enabled (jitsi#14236) feat(android): replaced NotificationChannels with NotificationUtils feat(android): update media projection notification build (jitsi#14365) feat(лоббъ): Admin set function for multiple items. feat(android): separate MediaProjection and OngoingConference notifications (jitsi#14363) fix(prejoin) adjust recording warning (jitsi#14361) feat(android): fixed screen sharing for Android 33 (jitsi#14359) fix: Fixes polls parsing. feat(transcript) add ability to dump transcript for debugging fix(whiteboard) handle metadata being null chore(deps) lib-jitsi-meet@latest feat(prejoin) display recording warning (jitsi#14347) feat: Notify jicofo when room_metadata changes the config form. (jitsi#14346) feat(recordings) send recordings metadata code review fix(recording) ensure recording label is shown when transcription is on fix(recording) do not show advanced options for users with local recording rights ... # Conflicts: # android/build.gradle # android/gradle.properties # ios/Podfile.lock # ios/app/broadcast-extension/Info.plist # ios/app/src/Info.plist # ios/app/watchos/app/Info.plist # ios/app/watchos/extension/Info.plist # ios/sdk/src/Info.plist # ios/sdk/src/Lite-Info.plist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.