Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(prejoin) default to enabled #14236

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Conversation

saghul
Copy link
Member

@saghul saghul commented Jan 16, 2024

No description provided.

@saghul saghul requested a review from damencho January 16, 2024 10:22
@saghul saghul force-pushed the prejoin-default-enabled branch from a2e0524 to 5eb2501 Compare January 16, 2024 11:04
damencho
damencho previously approved these changes Jan 16, 2024
@damencho
Copy link
Member

Hah this broke the teats for some reason

@saghul
Copy link
Member Author

saghul commented Jan 16, 2024

I thought we set it to disabled with URL parameters?!

@damencho
Copy link
Member

Nothing in the logs, many screenshots show prejoin so there must be a case where the URL setting is not working ...

@saghul
Copy link
Member Author

saghul commented Jan 16, 2024

Nothing in the logs, many screenshots show prejoin so there must be a case where the URL setting is not working ...

I'll look into it.

@damencho damencho force-pushed the prejoin-default-enabled branch from 5eb2501 to 831acaa Compare February 13, 2024 16:44
@damencho damencho merged commit 7e0b00b into jitsi:master Feb 13, 2024
8 checks passed
iospro pushed a commit to iospro/jitsi-meet that referenced this pull request Feb 26, 2024
…-audio

* develop/custom-24.0: (717 commits)
  chore(rn, versions): bump app and sdk versions
  feat(conference/recordin): Fix always on labels (jitsi#14368)
  chore(deps) lib-jitsi-meet@latest
  feat(prejoin) default to enabled (jitsi#14236)
  feat(android): replaced NotificationChannels with NotificationUtils
  feat(android): update media projection notification build (jitsi#14365)
  feat(лоббъ): Admin set function for multiple items.
  feat(android): separate MediaProjection and OngoingConference notifications (jitsi#14363)
  fix(prejoin) adjust recording warning (jitsi#14361)
  feat(android): fixed screen sharing for Android 33 (jitsi#14359)
  fix: Fixes polls parsing.
  feat(transcript) add ability to dump transcript for debugging
  fix(whiteboard) handle metadata being null
  chore(deps) lib-jitsi-meet@latest
  feat(prejoin) display recording warning (jitsi#14347)
  feat: Notify jicofo when room_metadata changes the config form. (jitsi#14346)
  feat(recordings) send recordings metadata
  code review
  fix(recording) ensure recording label is shown when transcription is on
  fix(recording) do not show advanced options for users with local recording rights
  ...

# Conflicts:
#	android/build.gradle
#	android/gradle.properties
#	ios/Podfile.lock
#	ios/app/broadcast-extension/Info.plist
#	ios/app/src/Info.plist
#	ios/app/watchos/app/Info.plist
#	ios/app/watchos/extension/Info.plist
#	ios/sdk/src/Info.plist
#	ios/sdk/src/Lite-Info.plist
iospro pushed a commit to iospro/jitsi-meet that referenced this pull request Feb 26, 2024
* develop/custom-24.0: (717 commits)
  chore(rn, versions): bump app and sdk versions
  feat(conference/recordin): Fix always on labels (jitsi#14368)
  chore(deps) lib-jitsi-meet@latest
  feat(prejoin) default to enabled (jitsi#14236)
  feat(android): replaced NotificationChannels with NotificationUtils
  feat(android): update media projection notification build (jitsi#14365)
  feat(лоббъ): Admin set function for multiple items.
  feat(android): separate MediaProjection and OngoingConference notifications (jitsi#14363)
  fix(prejoin) adjust recording warning (jitsi#14361)
  feat(android): fixed screen sharing for Android 33 (jitsi#14359)
  fix: Fixes polls parsing.
  feat(transcript) add ability to dump transcript for debugging
  fix(whiteboard) handle metadata being null
  chore(deps) lib-jitsi-meet@latest
  feat(prejoin) display recording warning (jitsi#14347)
  feat: Notify jicofo when room_metadata changes the config form. (jitsi#14346)
  feat(recordings) send recordings metadata
  code review
  fix(recording) ensure recording label is shown when transcription is on
  fix(recording) do not show advanced options for users with local recording rights
  ...

# Conflicts:
#	android/build.gradle
#	android/gradle.properties
#	ios/Podfile.lock
#	ios/app/broadcast-extension/Info.plist
#	ios/app/src/Info.plist
#	ios/app/watchos/app/Info.plist
#	ios/app/watchos/extension/Info.plist
#	ios/sdk/src/Info.plist
#	ios/sdk/src/Lite-Info.plist
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants