-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(jwt): Support JWKS endpoint and improve JWT aud claim handling #15657
base: master
Are you sure you want to change the base?
Conversation
Hi, thanks for your contribution! |
Thanks I will try to look at it next week. You have tested it on a machine where also coturn is installed? |
Yes.
|
And how did you test it? |
I am testing it with RS256 keys produced by Keycloak.
Since the aud claim can be of two varieties as per RFC 7519, I used two types of keys:
Type B - claim as an array:
For While the changes are made to keep backwards compatibility and require zero extra configuration, I haven't tested to ensure that the current style of cacheKeysUrl ( |
I will try to test it next week. It was added to accommodate the firebase tokens that meet.jit.si uses. |
But that code will not handle this: |
Yeah you're right. Let me make a few changes to accommodate that format as well. I can push the commit sometime this week. How can we have testing for this? I wrote a simple script to test these functions for a few cases, but not sure if I should push the test files to the repo or not. I couldn't find any tests directory here. |
Nope there are no tests, I was planning to test it manually |
This PR addresses issue #15182 by adding support for JWKS (JSON Web Key Set) endpoints and improving the handling of JWT aud claims. The changes include:
Support for JWKS Endpoint:
JWT aud Claim Handling Improvement:
These changes
maintain backward compatibility
with existing key cache endpoints and 'aud' claim handling, while enhancing standards compatibility. These changes enable Jitsi Meet to work seamlessly with identity providers that use JWKS for key distribution and improve compliance with OIDC standards.Changes have been manually tested on Jitsi Debian Setup.