Skip to content

Commit 612792b

Browse files
authored
supress test warnings (#54)
* supress test warnings * minor adjustments * update branch alias for dev master
1 parent 9ce0157 commit 612792b

File tree

4 files changed

+6
-6
lines changed

4 files changed

+6
-6
lines changed

composer.json

+3-3
Original file line numberDiff line numberDiff line change
@@ -22,15 +22,15 @@
2222
"ext-json": "*"
2323
},
2424
"require-dev": {
25-
"phpunit/phpunit": "9.4.*",
25+
"phpunit/phpunit": "^9.4",
2626
"squizlabs/php_codesniffer": "^3.5.4",
2727
"phpstan/phpstan": "^0.12",
2828
"php-mock/php-mock-phpunit": "^2.6",
2929
"kwn/php-rdkafka-stubs": "^2.0.0",
3030
"rregeer/phpunit-coverage-check": "^0.3.1",
3131
"johnkary/phpunit-speedtrap": "^3.1",
3232
"flix-tech/avro-serde-php": "^1.4",
33-
"infection/infection": "^0.18"
33+
"infection/infection": "^0.20"
3434
},
3535
"autoload": {
3636
"psr-4": {
@@ -42,7 +42,7 @@
4242
},
4343
"extra": {
4444
"branch-alias": {
45-
"dev-master": "1.0-dev"
45+
"dev-master": "2.0-dev"
4646
}
4747
}
4848
}

docker/dev/php/Dockerfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM php:7.3-cli-alpine3.12
1+
FROM php:7.4-cli-alpine3.12
22

33
ARG HOST_USER_ID
44
ARG HOST_USER

src/Consumer/KafkaConsumerBuilder.php

-1
Original file line numberDiff line numberDiff line change
@@ -311,7 +311,6 @@ public function build(): KafkaConsumerInterface
311311
$this->registerCallbacks($kafkaConfig);
312312

313313
//create RdConsumer
314-
315314
if (self::CONSUMER_TYPE_LOW_LEVEL === $this->consumerType) {
316315
if (null !== $this->consumeCallback) {
317316
throw new KafkaConsumerBuilderException(

tests/Unit/Consumer/KafkaConsumerBuilderTest.php

+2-1
Original file line numberDiff line numberDiff line change
@@ -332,13 +332,13 @@ public function testBuildLowLevelSuccess(): void
332332
$callback = function ($kafka, $errId, $msg) {
333333
// Anonymous test method, no logic required
334334
};
335-
336335
/** @var $consumer KafkaLowLevelConsumer */
337336
$consumer = $this->kafkaConsumerBuilder
338337
->withAdditionalBroker('localhost')
339338
->withAdditionalSubscription('test-topic')
340339
->withRebalanceCallback($callback)
341340
->withErrorCallback($callback)
341+
->withLogCallback($callback)
342342
->withConsumerType(KafkaConsumerBuilder::CONSUMER_TYPE_LOW_LEVEL)
343343
->build();
344344

@@ -391,6 +391,7 @@ public function testBuildHighLevelSuccess(): void
391391
->withAdditionalSubscription('test-topic')
392392
->withRebalanceCallback($callback)
393393
->withErrorCallback($callback)
394+
->withLogCallback($callback)
394395
->build();
395396

396397
$conf = $consumer->getConfiguration();

0 commit comments

Comments
 (0)