Revert "Raise error on unknown primary key."

This reverts commit ee2be43.

Author: jonleighton

activerecord/lib/active_record/attribute_methods/primary_key.rb

@@ -14,8 +14,6 @@ module ClassMethods
         # primary_key_prefix_type setting, though.
         def primary_key
           @primary_key ||= reset_primary_key
-          raise ActiveRecord::UnknownPrimaryKey.new(self) unless @primary_key
-          @primary_key
         end
 
         # Returns a quoted version of the primary key name, used to construct SQL statements.
@@ -31,11 +29,6 @@ def reset_primary_key #:nodoc:
           key
         end
 
-        def primary_key? #:nodoc:
-          @primary_key ||= reset_primary_key
-          !@primary_key.nil?
-        end
-
         def get_primary_key(base_name) #:nodoc:
           return 'id' unless base_name && !base_name.blank?
 

activerecord/lib/active_record/attribute_methods/read.rb

@@ -40,7 +40,7 @@ def define_method_attribute(attr_name)
               define_read_method(attr_name, attr_name, columns_hash[attr_name])
             end
 
-            if primary_key? && attr_name == primary_key && attr_name != "id"
+            if attr_name == primary_key && attr_name != "id"
               define_read_method('id', attr_name, columns_hash[attr_name])
             end
           end
@@ -63,7 +63,7 @@ def define_read_method(method_name, attr_name, column)
             cast_code = column.type_cast_code('v')
             access_code = "(v=@attributes['#{attr_name}']) && #{cast_code}"
 
-            unless primary_key? && attr_name.to_s == primary_key.to_s
+            unless attr_name.to_s == self.primary_key.to_s
               access_code.insert(0, "missing_attribute('#{attr_name}', caller) unless @attributes.has_key?('#{attr_name}'); ")
             end
 
@@ -107,7 +107,7 @@ def read_attribute(attr_name)
 
       def _read_attribute(attr_name)
         attr_name = attr_name.to_s
-        attr_name = self.class.primary_key? && self.class.primary_key if attr_name == 'id'
+        attr_name = self.class.primary_key if attr_name == 'id'
         value = @attributes[attr_name]
         unless value.nil?
           if column = column_for_attribute(attr_name)

activerecord/lib/active_record/attribute_methods/write.rb

@@ -18,7 +18,7 @@ def define_method_attribute=(attr_name)
               end
             end
 
-            if primary_key? && attr_name == primary_key && attr_name != "id"
+            if attr_name == primary_key && attr_name != "id"
               generated_attribute_methods.module_eval("alias :id= :'#{primary_key}='")
             end
           end

activerecord/lib/active_record/base.rb

@@ -708,7 +708,7 @@ def table_exists?
       # Returns an array of column objects for the table associated with this class.
       def columns
         if defined?(@primary_key)
-          connection_pool.primary_keys[table_name] ||= @primary_key
+          connection_pool.primary_keys[table_name] ||= primary_key
         end
 
         connection_pool.columns[table_name]
@@ -953,7 +953,7 @@ def before_remove_const #:nodoc:
       # objects of different types from the same table.
       def instantiate(record)
         sti_class = find_sti_class(record[inheritance_column])
-        record_id = sti_class.primary_key? && record[sti_class.primary_key]
+        record_id = sti_class.primary_key && record[sti_class.primary_key]
 
         if ActiveRecord::IdentityMap.enabled? && record_id
           if (column = sti_class.columns_hash[sti_class.primary_key]) && column.number?
@@ -1941,9 +1941,8 @@ def ensure_proper_type
 
       # The primary key and inheritance column can never be set by mass-assignment for security reasons.
       def self.attributes_protected_by_default
-        default = [ inheritance_column ]
-        default << primary_key if primary_key?
-        default << 'id' unless primary_key? && primary_key == 'id'
+        default = [ primary_key, inheritance_column ]
+        default << 'id' unless primary_key.eql? 'id'
         default
       end
 

activerecord/lib/active_record/errors.rb

@@ -169,18 +169,4 @@ def initialize(errors)
       @errors = errors
     end
   end
-
-  # Raised when a model attempts to fetch its primary key from the database, but the table
-  # has no primary key declared.
-  class UnknownPrimaryKey < ActiveRecordError
-    attr_reader :model
-
-    def initialize(model)
-      @model = model
-    end
-
-    def message
-      "Unknown primary key for table #{model.table_name} in model #{model}."
-    end
-  end
 end

activerecord/lib/active_record/fixtures.rb

@@ -622,7 +622,7 @@ def table_rows
 
     private
       def primary_key_name
-        @primary_key_name ||= model_class && model_class.primary_key? && model_class.primary_key
+        @primary_key_name ||= model_class && model_class.primary_key
       end
 
       def has_primary_key_column?

activerecord/lib/active_record/persistence.rb

@@ -314,7 +314,7 @@ def create
 
       new_id = self.class.unscoped.insert attributes_values
 
-      self.id ||= new_id if self.class.primary_key?
+      self.id ||= new_id if self.class.primary_key
 
       IdentityMap.add(self) if IdentityMap.enabled?
       @new_record = false

activerecord/lib/active_record/relation.rb

@@ -13,7 +13,7 @@ class Relation
 
     # These are explicitly delegated to improve performance (avoids method_missing)
     delegate :to_xml, :to_yaml, :length, :collect, :map, :each, :all?, :include?, :to => :to_a
-    delegate :table_name, :quoted_table_name, :primary_key, :primary_key?, :quoted_primary_key, :connection, :column_hash,:to => :klass
+    delegate :table_name, :quoted_table_name, :primary_key, :quoted_primary_key, :connection, :column_hash,:to => :klass
 
     attr_reader :table, :klass, :loaded
     attr_accessor :extensions, :default_scoped
@@ -36,7 +36,7 @@ def initialize(klass, table)
     def insert(values)
       primary_key_value = nil
 
-      if primary_key? && Hash === values
+      if primary_key && Hash === values
         primary_key_value = values[values.keys.find { |k|
           k.name == primary_key
         }]
@@ -70,7 +70,7 @@ def insert(values)
       conn.insert(
         im,
         'SQL',
-        primary_key? && primary_key,
+        primary_key,
         primary_key_value,
         nil,
         binds)

activerecord/lib/active_record/transactions.rb

@@ -303,7 +303,7 @@ def with_transaction_returning_status
     # Save the new record state and id of a record so it can be restored later if a transaction fails.
     def remember_transaction_record_state #:nodoc
       @_start_transaction_state ||= {}
-      @_start_transaction_state[:id] = id if self.class.primary_key?
+      @_start_transaction_state[:id] = id if has_attribute?(self.class.primary_key)
       unless @_start_transaction_state.include?(:new_record)
         @_start_transaction_state[:new_record] = @new_record
       end

activerecord/test/cases/attribute_methods/read_test.rb

@@ -24,10 +24,6 @@ def self.column_names
           def self.primary_key
           end
 
-          def self.primary_key?
-            false
-          end
-
           def self.columns
             column_names.map { FakeColumn.new(name) }
           end