Skip to content

Commit 4c6d92a

Browse files
paulwcyjoeferner
authored andcommitted
use GetBackingStore() instead of GetContents(); upgrade nan version
1 parent bc557ad commit 4c6d92a

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,8 @@
2929
"async": "2.6.1",
3030
"find-java-home": "0.2.0",
3131
"glob": "7.1.3",
32-
"lodash": "4.17.14",
33-
"nan": "2.14.0"
32+
"lodash": "4.17.15",
33+
"nan": "2.14.1"
3434
},
3535
"devDependencies": {
3636
"chalk": "2.4.1",

src/utils.cpp

+5-1
Original file line numberDiff line numberDiff line change
@@ -484,7 +484,11 @@ jvalueType javaGetArrayComponentType(JNIEnv *env, jobjectArray array) {
484484
#if (NODE_VERSION_AT_LEAST(4, 0, 0))
485485
v8::Local<v8::ArrayBuffer> newArrayBuffer(void* elems, size_t length) {
486486
v8::Local<v8::ArrayBuffer> ab = v8::ArrayBuffer::New(v8::Isolate::GetCurrent(), length);
487-
memcpy(ab->GetContents().Data(), elems, length);
487+
#if (NODE_MAJOR_VERSION >= 8)
488+
memcpy(ab->GetBackingStore()->Data(), elems, length);
489+
#else
490+
memcpy(ab->GetContents().Data(), elems, length);
491+
#endif
488492
return ab;
489493
}
490494
#endif

0 commit comments

Comments
 (0)