Skip to content

Commit 84a0f9b

Browse files
author
Konstantin Burykin
committed
fix BLOB reading
We do not need these deletes because `node::Buffer::New` accepts `RandomBytesFree` callback for deleting `buffer` by GC. fixes #92
1 parent aa46f36 commit 84a0f9b

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

src/connection.cpp

-2
Original file line numberDiff line numberDiff line change
@@ -699,7 +699,6 @@ Local<Object> Connection::CreateV8ObjectFromRow(ExecuteBaton* baton, vector<colu
699699
v8::Local<v8::Object> v8Buffer = bufferConstructor->NewInstance(3, constructorArgs);
700700
obj->Set(String::New(col->name.c_str()), v8Buffer);
701701
delete v;
702-
delete[] buffer;
703702
break;
704703
}
705704
break;
@@ -829,7 +828,6 @@ void Connection::handleResult(ExecuteBaton* baton, Handle<Value> (&argv)[2]) {
829828
v8::Handle<v8::Value> constructorArgs[3] = { uni::BufferToHandle(nodeBuff), v8::Integer::New(lobLength), v8::Integer::New(0) };
830829
v8::Local<v8::Object> v8Buffer = bufferConstructor->NewInstance(3, constructorArgs);
831830
obj->Set(String::New(returnParam.c_str()), v8Buffer);
832-
delete [] buffer;
833831
break;
834832
}
835833
case OutParam::OCCIDATE:

0 commit comments

Comments
 (0)