Improve error handling and logging (#8)

Author: johansenja

lib/ruby_lsp/rails/factory_bot/server_addon.rb

@@ -23,17 +23,21 @@ def initialize(stdout, stderr, capabilities)
 
         def name = FactoryBot::ADDON_NAME
 
-        def execute(request, params)
+        def execute(request, params) # rubocop:disable Metrics/MethodLength
           case request.to_sym
           when :factories
             collection = FactoryHandler.new.execute(params)
           when :traits
             collection = TraitHandler.new.execute(params)
           when :attributes
             collection = AttributeHandler.new.execute(params)
+          else
+            return send_error_response("#{request} no supported")
           end
 
-          send_result(collection)
+          send_result(collection || [])
+        rescue => e # rubocop:disable Style/RescueStandardError
+          send_error_response("An error occurred while fetching #{request} - #{e}")
         end
       end
     end

lib/ruby_lsp/rails/factory_bot/server_addon/factory_handler.rb

@@ -12,12 +12,13 @@ class FactoryHandler < BaseHandler
 
           def fetch(params)
             name = params[:name]
-            ::FactoryBot.factories.select do |f|
+            factories = ::FactoryBot.factories.select do |f|
               name.nil? || name.empty? ? true : f.name.to_s.include?(params[:name])
             end
+            return factories, nil
           end
 
-          def serialise(factories)
+          def serialise(factories, *)
             factories.map do |fact|
               model_class = fact.send :class_name
 

lib/ruby_lsp/rails/factory_bot/server_addon/trait_handler.rb

@@ -17,7 +17,8 @@ def fetch(params)
             defined_traits = defined_traits(factory, trait_name_partial)
             internal_traits = internal_traits(factory.send(:class_name), trait_name_partial)
 
-            defined_traits.concat(internal_traits)
+            traits = defined_traits.concat(internal_traits)
+            return traits, nil
           rescue KeyError
             # FactoryBot throws a KeyError if the factory isn't found, so nothing to do here
           end
@@ -32,7 +33,7 @@ def internal_traits(factory_class_name, trait_name_partial)
             end
           end
 
-          def serialise(traits)
+          def serialise(traits, *)
             traits.map do |tr|
               source_location = block_for(tr)&.source_location
               {