Skip to content

Commit 6f6d577

Browse files
committed
Add entry to golinter for hardcoded credentials being ignored in test file
1 parent fb65fa0 commit 6f6d577

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

Diff for: .golangci.yml

+2
Original file line numberDiff line numberDiff line change
@@ -28,3 +28,5 @@ issues:
2828
text: "^func.*supervisor.*(waitSettle|waitSettleError).*$"
2929
linters:
3030
- unused
31+
- path: pkg/transfer-verifier/transfer-verifier-sui_test.go
32+
text: "G101: Potential hardcoded credentials"

Diff for: node/pkg/transfer-verifier/transfer-verifier-sui.go

+4-3
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ func (s *SuiTransferVerifier) GetEventFilter() string {
6161
// that maps the token address and chain ID to the amount requested out of the bridge. It does not return an error, because any faulty
6262
// events can be skipped, since they would likely fail being processed by the guardian as well. Debug level logging can be used to
6363
// reveal any potential locations where errors are occurring.
64-
func (s *SuiTransferVerifier) processEvents(events []SuiEvent, logger *zap.Logger) (requestedOutOfBridge map[string]*big.Int, numEventsProcessed int) {
64+
func (s *SuiTransferVerifier) processEvents(events []SuiEvent, logger *zap.Logger) (requestedOutOfBridge map[string]*big.Int, numEventsProcessed uint) {
6565
// Initialize the map to store the amount requested out of the bridge
6666
requestedOutOfBridge = make(map[string]*big.Int)
6767

@@ -205,9 +205,10 @@ func (s *SuiTransferVerifier) ProcessDigest(digest string, suiApiConnection SuiA
205205
zap.String("amountIn", amountIn.String()))
206206
}
207207

208-
logger.Info("Digest processed", zap.String("txDigest", digest), zap.Int("numEventsProcessed", numEventsProcessed), zap.Int("numChangesProcessed", numChangesProcessed))
208+
//nolint:gosec
209+
logger.Info("Digest processed", zap.String("txDigest", digest), zap.Int("numEventsProcessed", int(numEventsProcessed)), zap.Int("numChangesProcessed", numChangesProcessed))
209210

210-
return uint(numEventsProcessed), nil
211+
return numEventsProcessed, nil
211212
}
212213

213214
type SuiApiResponse interface {

0 commit comments

Comments
 (0)